Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp594617imm; Sat, 7 Jul 2018 04:16:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdZF23+eNtCP4Gj7aKKhKowpp4CK+rY8+vytfFQq5voj9UPk8bAY2OIqYpP85uidYJvMpIw X-Received: by 2002:a63:6e07:: with SMTP id j7-v6mr12688336pgc.251.1530962211861; Sat, 07 Jul 2018 04:16:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530962211; cv=none; d=google.com; s=arc-20160816; b=JNRlkgoYtGpXaKM+YSNCOBZZI5quRqcoOl9OeeKbA/a+HUh7NffQpgFH5hxJ37T1xK VyBV7gltlWuuWv6z6ZTCvjapL9R+C8KHFEWOk1t/yb6PQ3AOpeZwqwJPLvtLcNkyGFoH uLNOl3uBEIWj7RlcJj41J+JQhf1i1GTskYThkYEVRaOh1h4Iw72/ZH+p5ZPc1DWpl40w Ic6rjVsgrhoii8hJMklZGiTyOEae7TaCoYKED/Tncy5RccHG7Vdig1KVWBjCUV6paVS1 EZWkZ0sU+oO26Cjh0KpqurJeTqO6aGEyVptrmBy7XPX/ap3lwIRsdwNB6ssOXKbITI3B 7xZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=Idl9da+ff8qruZ59rU0Sj8VDVej4X589JdCVxmV5FYQ=; b=CneJuZnelqlI18Jg7qACIxp/l+HEtpZ8ffUfOmtIgVSdCbHM4p3BEjqJh04DVMAHyY RxXlF9VPFksOUYhzMAd1nhr8sGk42dCWcZg43D5n9oTkprqZxUJbu3+i+GVOG4DH/cbH NyEhD+jVRLikbA1nuxPrzo1vtSiuktRyGUAT6lfD+y3pH1WLuF2jJsxMk26QMSr7LNoX ipJegAY0Dpfg8KEC2zrhds3+v9iC2Ih+2JDpKEjYRDUihgOgvWL1vK+DhV6K62gdHNh3 bvsE1gHSRcViquXF5AfqDOC2hpks15c02DVUBhTCybi5yiHi9GU9Lo7TfmuR+Uhr5ors wvag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e36-v6si9815027pge.507.2018.07.07.04.16.37; Sat, 07 Jul 2018 04:16:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753810AbeGGLP6 (ORCPT + 99 others); Sat, 7 Jul 2018 07:15:58 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:51464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbeGGLP4 (ORCPT ); Sat, 7 Jul 2018 07:15:56 -0400 Received: from localhost (unknown [211.196.191.92]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 136F711AEC6EB; Sat, 7 Jul 2018 04:15:54 -0700 (PDT) Date: Sat, 07 Jul 2018 20:15:53 +0900 (KST) Message-Id: <20180707.201553.20530216509400327.davem@davemloft.net> To: keescook@chromium.org Cc: saeedm@mellanox.com, tariqt@mellanox.com, leon@kernel.org, vadimp@mellanox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5: Use 2-factor allocator calls From: David Miller In-Reply-To: <20180704172847.GA33621@beast> References: <20180704172847.GA33621@beast> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 07 Jul 2018 04:15:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Wed, 4 Jul 2018 10:28:47 -0700 > This restores the use of 2-factor allocation helpers that were already > fixed treewide. Please do not use open-coded multiplication; prefer, > instead, using 2-factor allocation helpers. > > Signed-off-by: Kees Cook Saeed and co., please review.