Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp711858imm; Sat, 7 Jul 2018 07:06:41 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfnxukEN7id8TkS2Jvr06pEIOyUxJydErO7s6a0x9pi65tReYIe5fWGA2upqRkZr8jCPr8v X-Received: by 2002:a65:520c:: with SMTP id o12-v6mr12902434pgp.15.1530972401713; Sat, 07 Jul 2018 07:06:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1530972401; cv=none; d=google.com; s=arc-20160816; b=v61XK2DaJACxb2Jp+qm/ig/Q8zym5PvNYjuLqhGvgHNYtwBqcWnvvHUfBb9+0k5bTH P6ciVw8Pirj0z6KkszDLXLZYQWMYClCGba6frE/q7ERr35r8WjVDK5XkwslAIIPQhkRu hDuGyD1wpu8H5ZOJdpBq2WkpNnjw+hHANVrhJ360VtimQfmt2u2bON9PR+CK7ZZatEf6 Vf5+YMb5FWErDFS+dp8Dt03pZJJw5RL2tYKaShy1dbfVsHx4eEavtmxMifNkAUI0t0GB nt/+vUtciYGrnKTz+Rl0SJv9GUnsqdnkZnUSobyWp6ZaV+16FCOyWVCJWqakDVIvpxsB 6hQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=zBwZQvWYstvEx8lScgLI42Zr0tOQSyOsLZzyZAUy2KY=; b=jjDP9XTGXHDGYQkzfRG+1D17L7mf2+/k+d3Hal2AAVh8EfmzN2ubdDPSWfaQr5wc/Z fySZPp5L8sdo8q+qef90MDlWMnnuSd4xH8xj36V0qXQ7HheQgvaR29jpYXqsymCeKw8G mBThmte9CdnxVGgHDdr3yoQBy1Q5i8RWJuV2WucXKdD90yfFYFZGsoiianvPZhvXg4q/ OvPZnilNESzRIQfClPsr+XM5Y1Rh09Z14cOOeqr3EgwNJRrLAXZC7K8Zh8rM8iA5k0sL Bg6D9IVy5xI3p4+RMj+vBjoUPhGtH+drAbITWB6JH7xg/w1uVwadKt0eVEyDWpwDvPnR WXFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m141-v6si11426038pfd.310.2018.07.07.07.06.27; Sat, 07 Jul 2018 07:06:41 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754052AbeGGOFY (ORCPT + 99 others); Sat, 7 Jul 2018 10:05:24 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52242 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753173AbeGGOFX (ORCPT ); Sat, 7 Jul 2018 10:05:23 -0400 Received: from localhost (unknown [37.168.185.56]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 3BF49DB7; Sat, 7 Jul 2018 14:05:21 +0000 (UTC) Date: Sat, 7 Jul 2018 16:05:18 +0200 From: Greg KH To: Tamir Suliman Cc: w.d.hubbs@gmail.com, speakup@linux-speakup.org, dhowells@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, chris@the-brannons.com Subject: Re: [PATCH 3/3] drivers/speakup: kobjects : Fixed Coding issues -Debugging Message-ID: <20180707140518.GB7052@kroah.com> References: <1530756740-14168-1-git-send-email-tsuliman@linuxvaults.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1530756740-14168-1-git-send-email-tsuliman@linuxvaults.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 05, 2018 at 02:12:20AM +0000, Tamir Suliman wrote: > Updated printk() of i18n messages to include KERN_INFO facility level to improve debuggin. > then later noticed that I forgot to add a space on printk. > > Signed-off-by: Tamir Suliman > --- > drivers/staging/speakup/kobjects.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 7e79f99..af664f0 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -740,7 +740,7 @@ static void report_msg_status(int reset, int received, int used, > snprintf(buf + (len - 1), sizeof(buf) - (len - 1), > " with %d reject%s\n", > rejected, rejected > 1 ? "s" : ""); > - printk(KERN_INFO "i18n messages rejected\n",buf); > + printk(KERN_INFO "i18n messages rejected\n", buf); > } > } > > -- > 1.8.3.1 Where are patches 1 and 2 of this series? And the changelog text does not match what the text itself does, so I can't take this as-is :( greg k-h