Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180707144527.6662-1-simon@lineageos.org>
References: <20180707144527.6662-1-simon@lineageos.org>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Sat, 7 Jul 2018 17:34:08 +0200
Message-ID: <CAJKOXPfUav7URsCDHFzMbtBiw5id+szVj_VtGJ-iu5ymmgWoXw@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: exynos: add max77693 irq configuration for midas
To:     Simon Shields <simon@lineageos.org>
Cc:     "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7 July 2018 at 16:45, Simon Shields <simon@lineageos.org> wrote:
> Currently, we assume that the bootloader has correctly configured
> the interrupt pin for max77693. This might not actually be the case -
> so it's better to configure it explicitly.
>
> Signed-off-by: Simon Shields <simon@lineageos.org>
> ---
>  arch/arm/boot/dts/exynos4412-midas.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
> index f35176a35a15..30760bf2eb71 100644
> --- a/arch/arm/boot/dts/exynos4412-midas.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
> @@ -156,6 +156,8 @@
>                         compatible = "maxim,max77693";
>                         interrupt-parent = <&gpx1>;
>                         interrupts = <5 IRQ_TYPE_EDGE_FALLING>;
> +                       pinctrl-names = "default";
> +                       pinctrl-0 = <&max77693_irq>;
>                         reg = <0x66>;
>
>                         regulators {
> @@ -1117,6 +1119,13 @@
>                 samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
>         };
>
> +       max77693_irq: max77693-irq {
> +               samsung,pins = "gpx1-5";
> +               samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
> +               samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> +               samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> +       };
> +

Please put it before hdmi-hpd (gpx3-7). What about the interrupt for
max77693 fuel gauge? Maybe another patch for it as well?

Best regards,
Krzysztof


>         sleep1: sleep-states {
>                 PIN_SLP(gpk0-0, PREV, NONE);
>                 PIN_SLP(gpk0-1, PREV, NONE);
> --
> 2.18.0
>