Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180618110731.57427-1-mika.westerberg@linux.intel.com>
 <20180618110731.57427-6-mika.westerberg@linux.intel.com> <20180707211401.GA13111@wunner.de>
 <20180708073130.GR2534@lahna.fi.intel.com>
In-Reply-To: <20180708073130.GR2534@lahna.fi.intel.com>
From:   Yehezkel Bernat <yehezkelshb@gmail.com>
Date:   Sun, 8 Jul 2018 12:56:18 +0300
Message-ID: <CA+CmpXvaE63kBreCMMw_+QwMb811Rjx7B1z5==cY9nQ39J_Ukw@mail.gmail.com>
Subject: Re: [PATCH 5/5] thunderbolt: Add support for runtime PM
To:     Mika Westerberg <mika.westerberg@linux.intel.com>
Cc:     lukas@wunner.de, LKML <linux-kernel@vger.kernel.org>,
        Andreas Noever <andreas.noever@gmail.com>,
        michael.jamet@intel.com, rjw@rjwysocki.net, christian@kellner.me,
        Mario Limonciello <mario.limonciello@dell.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 8, 2018 at 10:31 AM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> On Sat, Jul 07, 2018 at 11:14:01PM +0200, Lukas Wunner wrote:
> >
> > Because I'm fairly certain that
> > I do not get a PME for the Light Ridge in my MacBook Pro, but I'll test
> > this once more and modify negotiate_os_control() to grant PME control
> > to the OS.
>
> I think in case of Apple hardware, they handle the in some different
> means than PME (possibly part of chipset driver or ACPI method/event).

In addition to what already mentioned, many things have changed around power
management during Alpine Ridge development, some of them came later as FW
updates (and BIOS changes). Comparing Alpine ridge to Light Ridge here is
comparing oranges to, well, Apples.