Received: by 2002:ac0:a591:0:0:0:0:0 with SMTP id m17-v6csp1931099imm; Sun, 8 Jul 2018 14:51:48 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeU2YiHjICMQohpO+cfgj9D6fAEg29KSBdgVYGb9zKFqB0mpkJAkuTTDu3rXRBt7O/hfFQ3 X-Received: by 2002:a62:444d:: with SMTP id r74-v6mr18556411pfa.96.1531086707965; Sun, 08 Jul 2018 14:51:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531086707; cv=none; d=google.com; s=arc-20160816; b=F6rAxxhXKOAD34laM0XMvvpVfoSspwz79a0fhhcNEKO+lGBmSjoXNf2Tm4v5LFOCv8 P6WcD6Yb1cBzCEGPqUivlbw8d4xwztvBgCmJ57miPXefo898CCbjlmn0Lo3V9JNg0ZiV 473JK/OtQIv6fvF8pBa1uLS6jDkApGnrHtPdlBNNBi05odfFwXJbdDVKMO5y/kUyIa/J SDtIlzpAURedDui81/Fu77RQzfZWZcFVEqnX+GaxLu0gE7HoKcf4jG6zf2zlPIpJ3TCI 2n8wpSbzUg3dqzz0uRvJJnJo3627E+y88S0mAXJJtEVKEOwkBqmnirYRGgCirGDhiJTZ aHHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:arc-authentication-results; bh=WcGCbZYO1Uo0MgvaFBMMWGxobKDFTHZ4zw/8ApCGT+4=; b=0fPpgEhMapnaZT6c/8X1PlDmFY/Y3/3iyx/LEmXnZg17mgaz6pr4ukBsubPKDTMWw8 zgx3R6+VFNETz6JQU+8C0z5umdqI7+SWAt4WOHCNRK45LY+NsMOr6bUZ0m6DXMwLOTZs 1uYo1ku7l3V7LEe37wIM7RS5fhil0G64Yp3up4GO3+3FEnsa5hvT20xidfw42hgH5+fN fDB7s0ZweilDz8/jFbav1xy8ZfQF/IFvKZNC/b6Z+7hpFL89ut0hqLAKcRi4X8i1TXfc z894BjJyOzTLlUgGPzcb4yYUlWtRJNjcTnu7MF4JmSc9hoCI9AIF/K6C/izwNJ49QFB8 qmAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r12-v6si11788168pgv.285.2018.07.08.14.51.33; Sun, 08 Jul 2018 14:51:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933181AbeGHVuS convert rfc822-to-8bit (ORCPT + 99 others); Sun, 8 Jul 2018 17:50:18 -0400 Received: from mail.bootlin.com ([62.4.15.54]:38150 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932545AbeGHVuR (ORCPT ); Sun, 8 Jul 2018 17:50:17 -0400 Received: by mail.bootlin.com (Postfix, from userid 110) id C0B2D207DA; Sun, 8 Jul 2018 23:50:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from xps13 (unknown [91.224.148.103]) by mail.bootlin.com (Postfix) with ESMTPSA id 32DF3203B4; Sun, 8 Jul 2018 23:50:14 +0200 (CEST) Date: Sun, 8 Jul 2018 23:50:14 +0200 From: Miquel Raynal To: Wei Yongjun Cc: Boris Brezillon , Richard Weinberger , "David Woodhouse" , Brian Norris , Marek Vasut , Frieder Schrempf , , , Subject: Re: [PATCH -next v3] mtd: spinand: fix missing unlock on error Message-ID: <20180708235014.43648218@xps13> In-Reply-To: <1530696627-84879-1-git-send-email-weiyongjun1@huawei.com> References: <1530696061-76467-1-git-send-email-weiyongjun1@huawei.com> <1530696627-84879-1-git-send-email-weiyongjun1@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wei, Wei Yongjun wrote on Wed, 4 Jul 2018 09:30:27 +0000: > Add the missing unlock before return from function > spinand_mtd_(read|write) in the error handling case. > > Fixes: c898e0526fb6 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Signed-off-by: Wei Yongjun > --- > v2 -> v3: remove blank line > v1 -> v2: using break instead of return > --- Merged with the original commit too. Thanks, Miquèl