Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp294207imm; Mon, 9 Jul 2018 01:43:37 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdDnhXGSIjsC7M5VLdXEL9/a7xsH2p+0igk832nZYVOY1qb7RA6K1E+o8WYMt6rsfZUMBY9 X-Received: by 2002:a17:902:5a83:: with SMTP id r3-v6mr19393445pli.78.1531125817390; Mon, 09 Jul 2018 01:43:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531125817; cv=none; d=google.com; s=arc-20160816; b=KxxIePjevzacXQIvxyFT37Kr7sUIxBku2mjpAdQQtO2iYeqpvkizWWPAFhvgcdkQ9N UWt1t7MYbgB6/ivbmQCIr0HkkldHScsPfzjS8Gv341DTt7KHeBvbmN0Hc8a4oaQ7vygb 2o7ndNPVUbX2lKNhARgdq6z98U+djTvroZFyXkbtOyJqbky4fNVIEFX9RkUNGm2hBhQV X+XpnONfAwRK2suNR0SRsoKenXTXpr9pCPDYT90EaMvEC9AwNdkkCAkvaUToVnGg1TFu Gi1uM+2/thZWENyS9+E33ADCObuB52rkI0uodYdI3vC5ld4I1ykGV2TP/Yh9jztcv+t6 JOjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=ECSxS/Tu1J8yJoeTNndRt3Ju+K1/adxa0HpIrDBgnIk=; b=arLPrknRlC5Iv2YtbXyNBlyoQibG2tjZPIWZffTOaRCceiiaiAN48dZRvw7V7p0XmE nYqWiLOkNIE7lVWRaOXP++NNLMjlW8lwObFxFpEWfiizlGQMu7oy9tjY0T2d9y1S3NeS ba/JAxmIHF2I/VfHiHUP5q0+KjejN73f71YsYNHVx5mjIts5Uw+SjiR18FZIx7kppYEK THbKDlEXEHP0LqUo15yLB4aI1HyAAg2rMl/xW2LpZ5cX0Xere5bTAoVdlg41tH/Dvz9D ab9+M9SaNzAgWVWz1V5otOIFsdIhLYrxONq7O2zBHz/9+QuNBPysLQiI9ijY6mwzzYiU sVOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Ujzvu4GO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l81-v6si15435415pfa.368.2018.07.09.01.43.23; Mon, 09 Jul 2018 01:43:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=Ujzvu4GO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932806AbeGIIly (ORCPT + 99 others); Mon, 9 Jul 2018 04:41:54 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:32845 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754580AbeGIIhM (ORCPT ); Mon, 9 Jul 2018 04:37:12 -0400 Received: by mail-ed1-f66.google.com with SMTP id x5-v6so9594674edr.0 for ; Mon, 09 Jul 2018 01:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ECSxS/Tu1J8yJoeTNndRt3Ju+K1/adxa0HpIrDBgnIk=; b=Ujzvu4GOI7K6XVEjopEXycGdZ9LWKakpFhS/zA0CPD15VmKmAeRsUFb4aUkqG6ANNu jJ/xqNqHvQQYhUD5ytsfjzRpbCm0DggwDlTLJWgAxUstiFixoLWxOaKoH+1ZnjKWcmQc vq7Q6iAOH+1y9XfDBcIksZUkh/fg17DGudKiM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ECSxS/Tu1J8yJoeTNndRt3Ju+K1/adxa0HpIrDBgnIk=; b=s926yWkziPsh566qRQ9VAEw1/BQ0Q1NVRn8DC98NFPAAyvBUw1STFXsIJOd8SFnYPq b2wFm8vSxgWTQrqvmRXX7GJWH/7TJ/tJCX6VnOINRPs/ezSNnp8XGnjESHPcat7U3yA7 SL5oHGXDLQepNvk0AGxl2ufY7uker9PQWnt2a47ixJA0wjUhisjBSaai2arfmX9PJH3B OdUxtvVJofU4RVcHzpY14SBxNvpZLegvR4Qg/+ydqGZ7RBq5FypswgJlVbEMPiDuQlOI nHDdpF5y6Ohw1yBR61FXxkj8vT2IXmBpdWylsmoPrGgqOpWO1/Zlf9fLjl+D/+ZA1dor lzmw== X-Gm-Message-State: APt69E11Ii3UJSiWx/TvHzRcVdo9kLt8BDD4daaPbq+Vt7Gu+PR3dn4o AxrHFHZQv/CNnIqpWf8sJbPYvuDa X-Received: by 2002:a50:8e09:: with SMTP id 9-v6mr81843edw.101.1531125430737; Mon, 09 Jul 2018 01:37:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:5628:0:496f:7dc5:66d7:a057]) by smtp.gmail.com with ESMTPSA id 8-v6sm340067edv.77.2018.07.09.01.37.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jul 2018 01:37:10 -0700 (PDT) From: Daniel Vetter To: LKML Cc: DRI Development , Intel Graphics Development , Daniel Vetter , Daniel Vetter , Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: [PATCH 12/12] usb: use for_each_if Date: Mon, 9 Jul 2018 10:36:50 +0200 Message-Id: <20180709083650.23549-12-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180709083650.23549-1-daniel.vetter@ffwll.ch> References: <20180709083650.23549-1-daniel.vetter@ffwll.ch> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Avoids the inverted condition compared to the open-coded version. Signed-off-by: Daniel Vetter Cc: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index 4cdd515a4385..a9da7237c619 100644 --- a/include/linux/usb.h +++ b/include/linux/usb.h @@ -732,7 +732,7 @@ extern struct usb_device *usb_hub_find_child(struct usb_device *hdev, for (port1 = 1, child = usb_hub_find_child(hdev, port1); \ port1 <= hdev->maxchild; \ child = usb_hub_find_child(hdev, ++port1)) \ - if (!child) continue; else + for_each_if (child) /* USB device locking */ #define usb_lock_device(udev) device_lock(&(udev)->dev) -- 2.18.0