Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp378627imm; Mon, 9 Jul 2018 03:34:55 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfmchnIgFbqaoQ/WK08l/hGzHGRuVjBT1Y/YmELOSMt9FcZVcztMcJwYoW4XGo8h0gX4v0U X-Received: by 2002:a17:902:8207:: with SMTP id x7-v6mr19696241pln.57.1531132495312; Mon, 09 Jul 2018 03:34:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531132495; cv=none; d=google.com; s=arc-20160816; b=Ulu6krIU2Xu6Z1vl9T5z0hQuwMJyPyDmRBkNiJDDzoFjERdJ48uJR/t/BlhqHZjKaX aeEQi4yERlu2SwzwEblP4x6EvLiKEUvZpCUaymjSgrXilSvE/HE5pVda+XjuYYzUqkpv EOJ32S7xdDLnFLCWPPBk7pawmbNXTpGlZVU8MrhKIpZTmUz0EHdRQQ0dFAsr/Mx6kgS0 gFby4x3kRjfnEbBayQYGe7tPbOwoDSqUg2oUvwtaFQ1+S0kuaQZwi48rQb5bfYxjxJsE 9umT7lKMywn3eVh3Tx56AvOAManjJatbnksDKy6YmvluMLCao0Xl7RW4Wsnb4T+N7N79 Oq4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:message-id :content-language:content-transfer-encoding:in-reply-to:mime-version :user-agent:date:from:cc:to:subject:dkim-signature:dkim-filter :arc-authentication-results; bh=RYX5TkKYSXVy1gS5HLr22bi5VOviMJB/Xzgt3VsOfuA=; b=SFXfu3696/BAkKZH5UdPo6ekzxxGPT8QdgdcDeaxVU6E7/jSGfcAu0xOCSFhsBAGFj Xc/3gtOg51YDWz5qH9CcYAuiMl2zHdkrdPb7SSLQREbS/ruGNqqYxyvo199X9scHmnUK oxqwWJIOWFEiq8qHcLg2RVbHhxeD9KUJxLcHCwbMQZCXzQWnlDGDkKT97LzoxBppeoZi hcEf8JGz/pWkm9HaIq5psGzrMAcZS373FMGK7RHuh+7ICnIAgXHlfUixhColAM1fFzfe f953toJjmzco+1vXnfo8uEfyTfaWTFVaR+aD+Zfp5CPvDvB4rTcSGXqaUFzsmgavFEmH 9gpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=HRE2A4fI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a14-v6si15873799plt.382.2018.07.09.03.34.40; Mon, 09 Jul 2018 03:34:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=HRE2A4fI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932617AbeGIKdF (ORCPT + 99 others); Mon, 9 Jul 2018 06:33:05 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:54185 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbeGIKdD (ORCPT ); Mon, 9 Jul 2018 06:33:03 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180709103301euoutp02b076a1e7b7e073e966feb09df6e54745~-rMn2M40X1077210772euoutp02f for ; Mon, 9 Jul 2018 10:33:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180709103301euoutp02b076a1e7b7e073e966feb09df6e54745~-rMn2M40X1077210772euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1531132381; bh=RYX5TkKYSXVy1gS5HLr22bi5VOviMJB/Xzgt3VsOfuA=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=HRE2A4fIr0542ypN44a7CmTDuvojIw3/eN+u2qamxI2I+TJC5Nd9tElzM5nRaehc2 XVOWi370/eBoy3THwZ2/z+/LI4PjqOS2KM7C3pZv4tIqkWDKadkvRzV5FnT/Ej8rSr VGG3beAWhq174587MxqJW8zMxZU4f4v4s6VIWty0= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180709103300eucas1p2e563ce992d58f107f2897ea29ef887ad~-rMm1hKI13247332473eucas1p27; Mon, 9 Jul 2018 10:33:00 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id F4.B9.05700.CD9334B5; Mon, 9 Jul 2018 11:33:00 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20180709103259eucas1p1fc03f1da5e8964f903d09c5573923c10~-rMmDLdF-0476504765eucas1p12; Mon, 9 Jul 2018 10:32:59 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180709103259eusmtrp16da234ace5c77798c7d9915729ac6b8b~-rMlzhwJE1013010130eusmtrp1k; Mon, 9 Jul 2018 10:32:59 +0000 (GMT) X-AuditID: cbfec7f2-1dbff70000011644-37-5b4339dc2fa4 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 9C.41.04183.BD9334B5; Mon, 9 Jul 2018 11:32:59 +0100 (BST) Received: from [106.116.147.30] (unknown [106.116.147.30]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180709103259eusmtip1e47dd10b13c771f6a712b4a3925a1253~-rMlXieae2194921949eusmtip1-; Mon, 9 Jul 2018 10:32:59 +0000 (GMT) Subject: Re: [PATCH] mm: cma: honor __GFP_ZERO flag in cma_alloc() To: Christoph Hellwig Cc: Michal Hocko , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Morton , Michal Nazarewicz , Joonsoo Kim , Vlastimil Babka From: Marek Szyprowski Date: Mon, 9 Jul 2018 12:32:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0 MIME-Version: 1.0 In-Reply-To: <20180702133016.GA16909@infradead.org> Content-Transfer-Encoding: 7bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLKsWRmVeSWpSXmKPExsWy7djP87p3LJ2jDW7/EraYs34Nm8XpCYuY LFZ2N7NZbHp8jdXi8q45bBb31vxntXj9bRmzxYLjLawWsxv7GC1+/5jD5sDlsXmFlsemVZ1s Hps+TWL36Hp7hcnjxIzfLB6bl9R7rPvzisnjzIIj7B6fN8kFcEZx2aSk5mSWpRbp2yVwZUye mV/QxFKxe99DpgbGacxdjJwcEgImEvu+PWPtYuTiEBJYwSjxq2UqlPOFUWLvi6PsEM5nRomO y1uZYFo+9y5ng0gsZ5Ro7jnEDOG8Z5TYtPQX2GBhASeJ/ceWsYLYIgKaEreWt4MVMQscYZJ4 0nKNHSTBJmAo0fW2iw3EZhFQkZj4bSEjiC0qECMxb9FfFhCbV0BQ4uTMJ2A2p4CxxNHdU8Fs ZgF5ie1v5zBD2OISt57MZwJZICFwi11iSv91NojmMolTk4+xQdztIvFx0l92CFtY4tXxLVC2 jMTpyT0sEM3NjBLtM2axQzg9jBJb5+yA6raWOHz8ItA/HEDrNCXW79KHCDtKtJy6yQYSlhDg k7jxVhDiID6JSdumM0OEeSU62oQgqtUkZh1fB7f24IVLzBMYlWYheXMWktdmIXltFsLeBYws qxjFU0uLc9NTiw3zUsv1ihNzi0vz0vWS83M3MQIT2el/xz/tYPx6KekQowAHoxIP74dCp2gh 1sSy4srcQ4wSHMxKIryJVkAh3pTEyqrUovz4otKc1OJDjNIcLErivHEadVFCAumJJanZqakF qUUwWSYOTqkGRhM+SaG3yc+6jcvDf0jWbRT98Vgy5PAbmeU8Z1eEnZtfmFEatZjP49PtBpva 5AcBKzIcuGSiVFMbnpWvtOp8zL5mQcJlzhdyLjP5DN5uZtkx5fHxwJcMcxeyr8qyu3voe4bE 0QypuHX/Zv8RCq9pnnisR2JOdac677p6930vdmXMz+w/+7IsUYmlOCPRUIu5qDgRABqN/K1g AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLIsWRmVeSWpSXmKPExsVy+t/xu7q3LZ2jDbpPKVjMWb+GzeL0hEVM Fiu7m9ksNj2+xmpxedccNot7a/6zWrz+tozZYsHxFlaL2Y19jBa/f8xhc+Dy2LxCy2PTqk42 j02fJrF7dL29wuRxYsZvFo/NS+o91v15xeRxZsERdo/Pm+QCOKP0bIryS0tSFTLyi0tslaIN LYz0DC0t9IxMLPUMjc1jrYxMlfTtbFJSczLLUov07RL0MibPzC9oYqnYve8hUwPjNOYuRk4O CQETic+9y9m6GLk4hASWMkps6TrKDpGQkTg5rYEVwhaW+HOtiw3EFhJ4yyixcZI1iC0s4CSx /9gysBoRAU2JW8vbwYYyCxxjknjzC2roRRaJ7tmvwBJsAoYSXW8hBvEK2EncmrWSCcRmEVCR mPhtISOILSoQI7Fy82uoGkGJkzOfsIDYnALGEkd3T2WBWGAmMW/zQ6hl8hLb386BssUlbj2Z zzSBUWgWkvZZSFpmIWmZhaRlASPLKkaR1NLi3PTcYiO94sTc4tK8dL3k/NxNjMCo3Xbs55Yd jF3vgg8xCnAwKvHwfih0ihZiTSwrrsw9xCjBwawkwptoBRTiTUmsrEotyo8vKs1JLT7EaAr0 3ERmKdHkfGBCySuJNzQ1NLewNDQ3Njc2s1AS5z1vUBklJJCeWJKanZpakFoE08fEwSnVwLhz 8mbbJxMP/3vfynzW+FpVpahHVtHDV+/0Lrz8/yJO3P+H3d0Em5DFqn53JA+zTmdzurCKy0PM 5oL7/NZIMxHv2MrAxkNehXeOF/P1M/4onphbtvFM8tfoS5W7I07aNb6XV6672S0fMXlR7pYN ukoKB47qJIrerp/62Xmh79vKQwy27qd+WCixFGckGmoxFxUnAgDimMgP8AIAAA== Message-Id: <20180709103259eucas1p1fc03f1da5e8964f903d09c5573923c10~-rMmDLdF-0476504765eucas1p12@eucas1p1.samsung.com> X-CMS-MailID: 20180709103259eucas1p1fc03f1da5e8964f903d09c5573923c10 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180613085851eucas1p20337d050face8ff8ea87674e16a9ccd2 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180613085851eucas1p20337d050face8ff8ea87674e16a9ccd2 References: <20180613085851eucas1p20337d050face8ff8ea87674e16a9ccd2~3rI_9nj8b0455904559eucas1p2C@eucas1p2.samsung.com> <20180613122359.GA8695@bombadil.infradead.org> <20180613124001eucas1p2422f7916367ce19fecd40d6131990383~3uKFrT3ML1977219772eucas1p2G@eucas1p2.samsung.com> <20180613125546.GB32016@infradead.org> <20180613133913.GD20315@dhcp22.suse.cz> <20180702132335eucas1p1323fbf51cd5e82a59939d72097acee04~9kAizDyji0466904669eucas1p1w@eucas1p1.samsung.com> <20180702133016.GA16909@infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, On 2018-07-02 15:30, Christoph Hellwig wrote: > On Mon, Jul 02, 2018 at 03:23:34PM +0200, Marek Szyprowski wrote: >> What about clearing the allocated buffer? Should it be another bool >> parameter, >> done unconditionally or moved to the callers? > Please keep it in the callers. I plan to push it up even higher > from the current callers short to midterm. Okay, I will post a patch with this approach then. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland