Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Jul 2018 13:26:08 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        pascal paillet <p.paillet@st.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        rafael.j.wysocki@intel.co
Subject: Re: Applied "regulator: core: Link consumer with regulator driver"
 to the regulator tree
Message-ID: <20180709122608.GE16082@sirena.org.uk>
References: <CGME20180709111753eucas1p1f32e66fb2f7ea3216097cd72a132355d@eucas1p1.samsung.com>
 <E1fb8Ti-00026e-NU@debutante>
 <20180709111753eucas1p1f32e66fb2f7ea3216097cd72a132355d~-rzycA5Rg0378203782eucas1p1C@eucas1p1.samsung.com>
 <CA+M3ks5ieu_6=rsfdp9QQuLJbbwJj2if26m_STF0QJJBD-6XKQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO"
Content-Disposition: inline
In-Reply-To: <CA+M3ks5ieu_6=rsfdp9QQuLJbbwJj2if26m_STF0QJJBD-6XKQ@mail.gmail.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--wTWi5aaYRw9ix9vO
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 09, 2018 at 02:13:35PM +0200, Benjamin Gaignard wrote:
> 2018-07-09 13:17 GMT+02:00 Marek Szyprowski <m.szyprowski@samsung.com>:

> > ------------[ cut here ]------------
> > WARNING: CPU: 1 PID: 1 at drivers/base/core.c:108
> > device_is_dependent+0xa4/0xb4
> > Modules linked in:
> > CPU: 1 PID: 1 Comm: swapper/0 Not tainted 4.18.0-rc3-next-20180706 #112

> > It looks that some more checks have to be done before adding a link between
> > regulator consumer and regulator driver, because it is not that uncommon
> > that
> > regulator consumer shares the parent device with regulator provider.

> Each time device_is_dependent() will return 1 we have a warn_on.
> It is strange since returning 1 is well documented on function description.
> I don't know if we can safely remove the warn_on or if their is a good
> reason to keep it.
> Rafael what do you think about that ?

It's trying to tell you that there's probably a higher level bug if
you're adding a link from a device to itself.  That's not super
unreasonable, though it is going to mean that every bit of generic code
like this adding links is going to have to add checks (or we have to
downgrade or make optional the WARN_ON).

--wTWi5aaYRw9ix9vO
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltDVF8ACgkQJNaLcl1U
h9B4fAf/f2M9nozSlq4ot+kHdRSov7AokXfHzhx1FnMeXpq85njfR+4zhazTZ8Aj
9ZGGKqopnmNY1GDaPTvSnSeK2PlXceWlBPDxtQ8Vqd0Ib2hDUWO6zcAmR5aJhJz6
z6KxW/fZxzNO6NzvE/ZDxyEYtBEoMM6Ek3lyoMDqVoqwhrGCjIJfUyKYVkYnbi3C
dUzHOslxY9xklS/RRPrGDcpoQL69d35K6CT2OY2EXzkkq/9ktDVcOBcm4GiPfdMZ
T9JMFlFNi59ygkG/kdATR+SVdb+QEshdTP7u7IDTnlgnc9Pik3TcoLnTFXV8B5yj
FkJl0hudWijqRhLYx+8x7aQ0vlkq5w==
=OZHh
-----END PGP SIGNATURE-----

--wTWi5aaYRw9ix9vO--