Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Jul 2018 16:25:07 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Sandipan Das <sandipan@linux.ibm.com>,
        Milian Wolff <milian.wolff@kdab.com>
Cc:     acme@kernel.org, linux-kernel@vger.kernel.org, namhyung@kernel.org,
        ravi.bangoria@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com
Subject: Re: [PATCH] perf script: Show correct offsets for DWARF-based
 unwinding
Message-ID: <20180709142507.GA7917@krava>
References: <20180703120555.32971-1-sandipan@linux.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180703120555.32971-1-sandipan@linux.ibm.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 03, 2018 at 05:35:55PM +0530, Sandipan Das wrote:

SNIP

> 
> After:
> 
>   # perf report --stdio --no-children -s sym,srcline -g address
> 
>   # Samples: 1  of event 'probe_libc:inet_pton'
>   # Event count (approx.): 1
>   #
>   # Overhead  Symbol                Source:Line
>   # ........  ....................  ...........
>   #
>      100.00%  [.] __GI___inet_pton  inet_pton.c
>               |
>               ---gaih_inet.constprop.7 getaddrinfo.c:537
>                  getaddrinfo getaddrinfo.c:2304
>                  main ping.c:519
>                  generic_start_main.isra.0 libc-start.c:308
>                  __libc_start_main libc-start.c:102
>   ...
> 
>   # perf script -F comm,ip,sym,symoff,srcline,dso
> 
>   ping
>               7fffb38aaf28 __GI___inet_pton+0x8 (/usr/lib64/libc-2.26.so)
>     inet_pton.c:68
>               7fffb385fa53 gaih_inet.constprop.7+0xf43 (/usr/lib64/libc-2.26.so)
>     getaddrinfo.c:537
>               7fffb38605b3 getaddrinfo+0x163 (/usr/lib64/libc-2.26.so)
>     getaddrinfo.c:2304
>                  130782d6f main+0x3df (/usr/bin/ping)
>     ping.c:519
>               7fffb377369f generic_start_main.isra.0+0x13f (/usr/lib64/libc-2.26.so)
>     libc-start.c:308
>               7fffb3773897 __libc_start_main+0xb7 (/usr/lib64/libc-2.26.so)
>     libc-start.c:102
> 
> Fixes: 67540759151a ("perf unwind: Use addr_location::addr instead of ip for entries")
> Signed-off-by: Sandipan Das <sandipan@linux.ibm.com>

looks good to me, Milian?

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka