Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Roy Pledge <roy.pledge@nxp.com>
To:     Laurentiu Tudor <laurentiu.tudor@nxp.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        Leo Li <leoyang.li@nxp.com>
CC:     Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        Horia Geanta <horia.geanta@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "catalin.marinas@arm.com" <catalin.marinas@arm.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to
 drivers/soc/fsl
Thread-Topic: [PATCH 1/2] staging:fsl-mc: Move DPIO from staging to
 drivers/soc/fsl
Thread-Index: AQHUFJguns4FeKPlNUC4EOaWb3eQ3g==
Date:   Mon, 9 Jul 2018 15:23:40 +0000
Message-ID: <VI1PR04MB44942CF2B2E5BA1C6CE8D17786440@VI1PR04MB4494.eurprd04.prod.outlook.com>
References: <20180705194113.16256-1-roy.pledge@nxp.com>
 <20180705194113.16256-2-roy.pledge@nxp.com>
 <119c6fc6-a32d-45a5-96ea-f6e9959b1e74@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f67047de-80b0-4dd0-6397-08d5e5aff32d
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2018 15:23:40.2768
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1199
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/9/2018 6:37 AM, Laurentiu Tudor wrote:=0A=
> Hi Roy,=0A=
>=0A=
> Couple of comments inline.=0A=
>=0A=
> On 05.07.2018 22:41, Roy Pledge wrote:=0A=
>> Move the NXP DPIO (Datapath I/O Driver) out of the=0A=
>> drivers/staging directory and into the drivers/soc/fsl directory.=0A=
>>=0A=
>> The DPIO driver enables access to Queue and Buffer Manager (QBMAN)=0A=
>> hardware on NXP DPAA2 devices. This is a prerequisite to moving the=0A=
>> DPAA2 Ethernet driver out of staging.=0A=
>>=0A=
>> Signed-off-by: Roy Pledge <roy.pledge@nxp.com>=0A=
>> ---=0A=
>>   MAINTAINERS                                                    |  2 +-=
=0A=
>>   drivers/crypto/caam/sg_sw_qm2.h                                |  2 +-=
=0A=
>>   drivers/crypto/caam/sg_sw_sec4.h                               |  2 +-=
=0A=
>>   drivers/soc/fsl/Kconfig                                        | 10 ++=
++++++++=0A=
>>   drivers/soc/fsl/Makefile                                       |  1 +=
=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/Makefile          |  0=
=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-cmd.h        |  0=
=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.c     |  2 =
+-=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.txt   |  0=
=0A=
> Maybe this should be converted to .rst and go in the already existing=0A=
> Documentation/networking/dpaa2/?=0A=
=0A=
I can look into converting this to RST but I'm not sure it belongs in=0A=
the networking documentation folder since=0A=
it will be used by other non networking drivers in the near future -=0A=
compress/decompress for example.=0A=
>=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-service.c    |  2 =
+-=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.c            |  0=
=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.h            |  0=
=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.c    |  2 =
+-=0A=
>>   drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.h    |  2 =
+-=0A=
>>   drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.h                 |  4 ++=
--=0A=
>>   drivers/staging/fsl-mc/bus/Kconfig                             |  9 --=
-------=0A=
>>   drivers/staging/fsl-mc/bus/Makefile                            |  2 --=
=0A=
>>   {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-fd.h |  0=
=0A=
>>   .../staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-global.h  |  0=
=0A=
>>   {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-io.h |  0=
=0A=
>>   20 files changed, 20 insertions(+), 20 deletions(-)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/Makefile (100%)=
=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-cmd.h (100%=
)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.c (9=
9%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-driver.txt =
(100%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio-service.c (=
99%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.c (100%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/dpio.h (100%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.c (=
99%)=0A=
>>   rename drivers/{staging/fsl-mc/bus =3D> soc/fsl}/dpio/qbman-portal.h (=
99%)=0A=
>>   rename {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-fd.=
h (100%)=0A=
>>   rename {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-glo=
bal.h (100%)=0A=
>>   rename {drivers/staging/fsl-mc/include =3D> include/soc/fsl}/dpaa2-io.=
h (100%)=0A=
> I received feedback in the past on mc-bus that a driver should limit to =
=0A=
> only one public header and one private one. Would it make sense to do =0A=
> the same for dpio too?=0A=
Looking at this the dpaa-2global.h file should probably be integrated=0A=
into the dpaa2-io.h file. =0A=
The dpaaa2-fd.h can be used by devices that don't need to used DPIO -=0A=
the definition of a frame descriptor=0A=
isn't DPIO specific so I would argue it should be kept in a seperate file.=
=0A=
 =0A=
>=0A=
> ---=0A=
> Best Regards, Laurentiu=0A=
=0A=
=0A=