Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Jul 2018 17:11:52 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>
Cc:     pascal paillet <p.paillet@st.com>, benjamin.gaignard@linaro.org,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Don't link consumers on the same device
Message-ID: <20180709161152.GH16082@sirena.org.uk>
References: <CGME20180709125425epcas1p2343265d3a6a826b2ace0ef584d062dac@epcas1p2.samsung.com>
 <20180709125402.32427-1-broonie@kernel.org>
 <20180709133215eucas1p138cd9714d802a446973ce90058ef0afb~-tpG-E94E1650416504eucas1p1I@eucas1p1.samsung.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="WRT3RXLOp/bBMgTI"
Content-Disposition: inline
In-Reply-To: <20180709133215eucas1p138cd9714d802a446973ce90058ef0afb~-tpG-E94E1650416504eucas1p1I@eucas1p1.samsung.com>
User-Agent: Mutt/1.10.0 (2018-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--WRT3RXLOp/bBMgTI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 09, 2018 at 03:32:14PM +0200, Marek Szyprowski wrote:

> This patch doesn't help, because wm8994 creates separate struct device for
> each registered regulator, so you need to check the regulator parents too,
> see my fixes below in the patch.

Ugh, right - I'd not looked at enough of the context to see what was
being checked.

> I don't like such fixes for this specific case. It's not that uncommon
> that a complex device provides various functionalities used by its
> components, so it is not a bad design to use regulator provided by
> its parent/grandparent/other ancestor device.

> Frankly, either the device_is_dependent() function should be exported and
> used in regulator core or device_link_add() should have another flag:
> DL_FLAG_SKIP_DEPENDANT.

Or it should just make the warning optional at the core level.

--WRT3RXLOp/bBMgTI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAltDiUcACgkQJNaLcl1U
h9BSXgf/Q1suVsCj60nXkSRxw6s3MFEQECAaWcff6O45Rf4PPWtlYWE+3gO3B1Fu
LKCdklusjVMizEvnZr0dF+EMKEtnwmvoy3GNXZnaKspM7sCI8R8nLR6mKnk19dgE
wIqyBICxeu+tFgpnrBcN6mr9rVfFt7zytoNNLTJljSoYSahtcBUiT0cBbc9SQmAo
/6GvsuzWErBS4gbUFX/zM08qPRJjMb0IohO0ZX1B7rJEQzzfYOOdind6jXmPVQT1
FvzTHvAXP28KI5QexE+QhYxY9yCEFy3pXbDUeM52IVYv6QqJoL1xTicERB2tv/u1
XTo/nOu9FEmFGVLBGUpSCY+rX5G1sQ==
=SU2f
-----END PGP SIGNATURE-----

--WRT3RXLOp/bBMgTI--