Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp726145imm; Mon, 9 Jul 2018 09:30:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdoeXsQeM95Mu14cieOBfwRu8l0v0jq0kl7ezh30etcPhB8GWt6+if2fPeAJ448GNrpbK8V X-Received: by 2002:a63:1f4d:: with SMTP id q13-v6mr19602162pgm.241.1531153835080; Mon, 09 Jul 2018 09:30:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531153835; cv=none; d=google.com; s=arc-20160816; b=o+mYCCjC5HDyJsCaFGKG3uB++rnVgdIOed+XBaqifsUV+5bfiotRd285Ix95lfos82 ttTS6FluGrhpMhEcye5GJ+XZrGoqHHhfXuagRRlzXd2c+PFCYpepX0fZ/WqlSkzuxhX9 VW/c+0kh/hy09r9Wso4HQmvUwS5iK02eOhyafl/Nxtra/9QbhDRdl4Lss6gQQOGH4fLb st8fbhs6HUxQnVMPvdpzSlTcjzuqs0HtGVpVMq5dGDYtchwsotcrpypMTJ5HLmjCc8Ch 1RUmvrK45rXNWyQy5iP/ssGqfiYEVVtkOoYzcwXg9Ypdnp6O2YY979cB+UnTc0JUvTww u/sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=v+ZuNOneHtAZX3ZjIBs+EZdOWl+DouoO/6xVIUQ06a8=; b=u/+YvzGiOPQOq3wcR1Pi8u3a85iW9BDu+MxCj3is2Z3O9IeeBPOItN1t5XF3VSdCNW M9WywmTYfucBvTtSWXDEsW5hQJxnR/R+ESkeDi8B4pNSqj/MKEnst67JUil/od4OO6Fu h4sB+BawvDIvSDlbKTJdSUmHadpDTcJtuYnI3pluY+0Y75y4GKPr5JQu4vAVi2o+NYXt lxD7kbJuOby9SKLO1IdLcYQdVtrWB/YQhJaD54DlBa2PX7/bZa3TA2cJUBLgxGUFRfAw rM5QiAYtJzoxX7wkpROIZyrJqLrQyzW5VczVgegNd04+O6kZ6fJ1kBeahfv1G0b9QCIr a8kg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y6-v6si14355840pgk.474.2018.07.09.09.30.20; Mon, 09 Jul 2018 09:30:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933519AbeGIQ3O (ORCPT + 99 others); Mon, 9 Jul 2018 12:29:14 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35908 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933370AbeGIQ2q (ORCPT ); Mon, 9 Jul 2018 12:28:46 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94D2A7D84D; Mon, 9 Jul 2018 16:28:45 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id F3AAE2156891; Mon, 9 Jul 2018 16:28:44 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20180709155618.GH30522@ZenIV.linux.org.uk> References: <20180709155618.GH30522@ZenIV.linux.org.uk> <20180708234630.GB700@sol.localdomain> <20180708210154.10423-1-ebiggers3@gmail.com> <31355.1531150319@warthog.procyon.org.uk> To: Al Viro Cc: dhowells@redhat.com, Eric Biggers , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH vfs/for-next 00/18] fs_context fixes MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <22922.1531153724.1@warthog.procyon.org.uk> Date: Mon, 09 Jul 2018 17:28:44 +0100 Message-ID: <22923.1531153724@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 09 Jul 2018 16:28:45 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Mon, 09 Jul 2018 16:28:45 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Al Viro wrote: > Egads... *If* you go for bool here, why not > return (mnt->mnt_flags & MNT_READONLY) || sb_rdonly(mnt->mnt_sb); > and be done with that? Fair point; I'll do that when I get back later. David