Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 9 Jul 2018 22:28:09 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ioana Radulescu <ruxandra.radulescu@nxp.com>
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, ioana.ciornei@nxp.com
Subject: Re: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check
Message-ID: <20180709192809.msmwmtmgj4yxrhme@mwanda>
References: <20180709150111.8875-1-ruxandra.radulescu@nxp.com>
 <20180709150111.8875-6-ruxandra.radulescu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180709150111.8875-6-ruxandra.radulescu@nxp.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 09, 2018 at 10:01:11AM -0500, Ioana Radulescu wrote:
> @@ -2385,6 +2365,12 @@ static int netdev_init(struct net_device *net_dev)
>  
>  	/* Set MTU upper limit; lower limit is 68B (default value) */
>  	net_dev->max_mtu = DPAA2_ETH_MAX_MTU;
> +	err = dpni_set_max_frame_length(priv->mc_io, 0, priv->mc_token,
> +					(u16)DPAA2_ETH_MFL);

The cast was there in the original code so this is not a comment on this
particular patch (which seems fine) but there is no need to cast.

Generally it's best to avoid unnecessary casts.  As a human reader, I
find the cast confusing.  It indicates that DPAA2_ETH_MFL somehow
requires special handling.  Perhaps it's negative or we are trying to
truncate away the high bits.  But neither of those things really make
sense.

From a static analysis perspective if DPAA2_ETH_MFL doesn't fit nicely
then we would want to generate a warning.  But the cast explicitly
disables the check.

regards,
dan carpenter