Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp978251imm; Mon, 9 Jul 2018 14:32:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfLedU++koaprwlaOTFTCeQ/ZGRTWmk3p1bvHKEbBpf+yv3lAo1St/DBiNflGy6ufCpn7hi X-Received: by 2002:a17:902:9681:: with SMTP id n1-v6mr22721241plp.244.1531171921928; Mon, 09 Jul 2018 14:32:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531171921; cv=none; d=google.com; s=arc-20160816; b=E3ymioToJ1DSkj1Q4wJgeyYGvrjobyhA9VoxnskW2fX8tXJwQRQQ09OQSrN5aP2smN IJxz+dNuTQJi2WBaLmH22pM8jvXT4ilUSkP8IVIu1YAh9Tl3UgP77OUM1RYwhrmQmN7r cmvSSoWHTylGcuP63GIcXUn1bM2CKCBypge4yev/SPJw3YRYUeK8LbTRQcJqzmJJY1Ob nDwlgFrvpFMEnqBdeaPTurW81TpF68ZdcttjB6QDqscVyXQ6C7cd1vSrehMvarTkwXzI cfGFMbce2zYhMu+He0yEhvTq81n5Z3wx/MdGeLugubA2C6pK0J4nJeZB7kZBNClNlDdh va6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=t+prvIaEQ5xCO4nKmVphnTt2DkGDHcwK/FAd/upOgew=; b=c7x73xM00pMAXtQrWQ/mn+rLglSmVVPHpfpQs4RFvXKQDVOjV/DYK+vhjq632ofw5h 2AfPvyeR/nVyHLabltPPm2w4tBpbBoRAI5OH/4FJlf1+2nEVHx7AKRmV//PPCTir0igk 7ix/qjzNMOchFIAP3blGkv/vyOU29biQKxALEMEa2fMHsXkO7RWaXzRVPFcC9sHK4H12 oU7LCg+RJUvMvpyn4wT4ZMFrrgXQc7YA0ss+VubETJYTZNppxCCOwkAtK6hcVKMRyw/c bRgdHpUfVWsrd5wEKKZV4bk5FaHrcU6Ce13qoR2Pa5pkK0JDGRUeIFsBcAhyxNpG9eoR OjPg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j10-v6si1442141pfh.3.2018.07.09.14.31.47; Mon, 09 Jul 2018 14:32:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933206AbeGIV3c (ORCPT + 99 others); Mon, 9 Jul 2018 17:29:32 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40778 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932980AbeGIV3b (ORCPT ); Mon, 9 Jul 2018 17:29:31 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id E37E2E2C; Mon, 9 Jul 2018 21:29:29 +0000 (UTC) Date: Mon, 9 Jul 2018 14:29:28 -0700 From: Andrew Morton To: Pavel Tatashin Cc: steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com, jrdr.linux@gmail.com, bhe@redhat.com, gregkh@linuxfoundation.org, vbabka@suse.cz, richard.weiyang@gmail.com, dave.hansen@intel.com, rientjes@google.com, mingo@kernel.org, osalvador@techadventures.net Subject: Re: [PATCH v4 0/3] sparse_init rewrite Message-Id: <20180709142928.c8af4a1ddf80c407fe66b224@linux-foundation.org> In-Reply-To: <20180709175312.11155-1-pasha.tatashin@oracle.com> References: <20180709175312.11155-1-pasha.tatashin@oracle.com> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin wrote: > In sparse_init() we allocate two large buffers to temporary hold usemap and > memmap for the whole machine. However, we can avoid doing that if we > changed sparse_init() to operated on per-node bases instead of doing it on > the whole machine beforehand. > > As shown by Baoquan > http://lkml.kernel.org/r/20180628062857.29658-1-bhe@redhat.com > > The buffers are large enough to cause machine stop to boot on small memory > systems. > > These patches should be applied on top of Baoquan's work, as > CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER is removed in that work. > > For the ease of review, I split this work so the first patch only adds new > interfaces, the second patch enables them, and removes the old ones. This clashes pretty significantly with patches from Baoquan and Oscar: mm-sparse-make-sparse_init_one_section-void-and-remove-check.patch mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix.patch mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix-2.patch mm-sparse-add-a-static-variable-nr_present_sections.patch mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch Is there duplication of intent here? Any thoughts on the prioritization of these efforts?