Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1089218imm; Mon, 9 Jul 2018 17:09:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf8w3uRqAuqGhqCSHSsmj9HIGwTXhPsfrR9EKj6frIm3ZIfuHdwsEBpp/+zkZjA1gCJXTMh X-Received: by 2002:a63:ab4c:: with SMTP id k12-v6mr14573076pgp.386.1531181350325; Mon, 09 Jul 2018 17:09:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531181350; cv=none; d=google.com; s=arc-20160816; b=YKmhSeyKhZC1hCUYZKpK0TFQ04RYsrqcq3yi1frCARYgCC2TOgKaHBtdSlS3rGPZU4 Hpcl/rM8XlCGs4sqtZITGSvDP+peh2Rht7hsCXVrV1O1iJFzbAI3qnadvB3+j5ZzXxlx OClshJpVfOalkujzSNBvsRWFYyGDEOc9lMy5zf5PYyiZt9naqurPKFKn7XpgmlE9eYRd vmF2PQ/EJ5f9WUt9ClrTKIPDlhZXYzfm+ZID2N8rqH8r+Tkx8ZbkfS/Tbt5E1DaFXJLu lOC9kAhjSu4ItWNSkAYPQEjfs32lCGXSV5GdTgGdLaUYvn1B5oXxkE24ecURYFH5fas6 mGAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=+jaGyoi8SqOtlR8GmiLxhE/ra25CxfLyrPfV59WsUpI=; b=ZmEmxvk/RCk6ZnlfesCTAv5lOBBUAw/M7o4dPEDNZhT9RinZr93uwjnPEjaOvyLQJQ 110gXhrTpc7JljAxWZd79g4m7dxpk0redMA2m6qLiXCHGW1EPCP1L0mHt7odABiBPYL6 YobSifBau1LK5jhC1SRQPw8UwOASuib3jepJYqgzleNAhFLDRqc7GwmQs/OwGGorlQrT o3fTS7nIkRq5Us7dEGJOPc6O4BIN3ClOdRNB85P4ZdLzvE5oa/6Q79oQ8Q0idoMnPMd5 suWzM1bH2yMT8ewC1NJmew8ZkxBb8N2kZ21q5JsGcZkKMFqKPLrL8Ii6NMG0SKF/UhFD U08Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a8-v6si15219107ple.222.2018.07.09.17.08.55; Mon, 09 Jul 2018 17:09:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933268AbeGJAIK (ORCPT + 99 others); Mon, 9 Jul 2018 20:08:10 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49564 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932993AbeGJAII (ORCPT ); Mon, 9 Jul 2018 20:08:08 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9834BAE7; Tue, 10 Jul 2018 00:08:07 +0000 (UTC) Date: Mon, 9 Jul 2018 17:08:06 -0700 From: Andrew Morton To: Baoquan He Cc: Pavel Tatashin , steven.sistare@oracle.com, daniel.m.jordan@oracle.com, linux-kernel@vger.kernel.org, kirill.shutemov@linux.intel.com, mhocko@suse.com, linux-mm@kvack.org, dan.j.williams@intel.com, jack@suse.cz, jglisse@redhat.com, jrdr.linux@gmail.com, gregkh@linuxfoundation.org, vbabka@suse.cz, richard.weiyang@gmail.com, dave.hansen@intel.com, rientjes@google.com, mingo@kernel.org, osalvador@techadventures.net Subject: Re: [PATCH v4 0/3] sparse_init rewrite Message-Id: <20180709170806.bc28d2affba0e903e946e057@linux-foundation.org> In-Reply-To: <20180709235604.GA2070@MiWiFi-R3L-srv> References: <20180709175312.11155-1-pasha.tatashin@oracle.com> <20180709142928.c8af4a1ddf80c407fe66b224@linux-foundation.org> <20180709235604.GA2070@MiWiFi-R3L-srv> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jul 2018 07:56:04 +0800 Baoquan He wrote: > Hi Andrew, > > On 07/09/18 at 02:29pm, Andrew Morton wrote: > > On Mon, 9 Jul 2018 13:53:09 -0400 Pavel Tatashin wrote: > > > For the ease of review, I split this work so the first patch only adds new > > > interfaces, the second patch enables them, and removes the old ones. > > > > This clashes pretty significantly with patches from Baoquan and Oscar: > > > > mm-sparse-make-sparse_init_one_section-void-and-remove-check.patch > > mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix.patch > > mm-sparse-make-sparse_init_one_section-void-and-remove-check-fix-2.patch > > mm-sparse-add-a-static-variable-nr_present_sections.patch > > mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch > > mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch > > > Is there duplication of intent here? Any thoughts on the > > prioritization of these efforts? > > The final version of my patches was posted here: > http://lkml.kernel.org/r/20180628062857.29658-1-bhe@redhat.com > > Currently, only the first three patches are merged. > > mm-sparse-add-a-static-variable-nr_present_sections.patch > mm-sparsemem-defer-the-ms-section_mem_map-clearing.patch > mm-sparse-add-a-new-parameter-data_unit_size-for-alloc_usemap_and_memmap.patch > > They are preparation patches, and the 4th patch is the formal fix patch: > [PATCH v6 4/5] mm/sparse: Optimize memmap allocation during sparse_init() > > The 5th patch is a clean up patch according to reviewer's suggestion: > [PATCH v6 5/5] mm/sparse: Remove CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER > > I think Pavel's patches sits on top of all above five patches. OK, thanks, I've just moved to the v6 series.