Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1334527imm; Mon, 9 Jul 2018 23:20:24 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeaY9EyhKWFelYv6KurtYaQJHi992rWCNRPdz1PrHl65n/YIpzPHBPwntuHoBrLVtZDTkri X-Received: by 2002:a63:fc44:: with SMTP id r4-v6mr21555448pgk.169.1531203624309; Mon, 09 Jul 2018 23:20:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531203624; cv=none; d=google.com; s=arc-20160816; b=JFK+3Pi6ilFUsK1/WnCaJej/uzUtDQEAXIfmp/9zLMD0mei6bb4pUFWB48v0NBMh4I 17TWqGM9kTZd6fSmyaf2D5JzNm6CxMhJfGhA+fS2yt+ZTageQn7jZvocEcJu4ayfVa33 BUcAGj71t/r6WesBxUIRfP6c2W/2/z7UizYBCU0o222BGcS7aLDCQeWZTWgz8HfY3C4w vMBo1Tdd8BH2t2qDD+e/zcZ15AXhArg6KnpyPJjxVXI+8UfOBqlFwcCEcv1OHLynjN2V fXqwfJh3OfzNQz9RgJ3cucI97ZzZu/WRCiNiV3jUJJbWX7choceeT04mwI/yx7kqkfG8 pl+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=lZWoNGmz6qR/8EKVvlrS3covjGGrkL6P+eUUJytX6lI=; b=QEv5rtC9LA63oOwirErFn8Dzi1sGRGF1+0HAH/wJElBqGbdzOadl1UjUfxJZivgAJ3 3dlyUrcRqxM9gScdOozpjTYJ6dK7Kk+FFFboDmjjcV1N5g8IACQ15AJN0JtLwMs64a2q 2Jg2jA7U9WtIPmT5pnr2RZXIg2JB+7mU4epHjZg9CpVdciqAF2VVS5eM675SxWSwY2xH AflmGUhZyMWX//yMJ7LdHU/KbpbRUKQn//WPZWhJu8bvbeRtPX0cy82N5OW9Cs4PZmEa OVV4AYreUKVCvP+YUvF+5sR3d4C5aXR+tNWaTiVDaCfZIU3cMDc3kP4H5VGkGlILFZ6f 2jDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f27-v6si15644533pgb.302.2018.07.09.23.20.09; Mon, 09 Jul 2018 23:20:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751317AbeGJGSc (ORCPT + 99 others); Tue, 10 Jul 2018 02:18:32 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:9167 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751099AbeGJGS3 (ORCPT ); Tue, 10 Jul 2018 02:18:29 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 1C1E2305D969; Tue, 10 Jul 2018 14:18:16 +0800 (CST) Received: from [127.0.0.1] (10.134.22.195) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.382.0; Tue, 10 Jul 2018 14:18:12 +0800 Subject: Re: [PATCH] f2fs: Keep alloc_valid_block_count in sync To: Daniel Rosenberg , Jaegeuk Kim , CC: , References: <20180710033242.177557-1-drosen@google.com> From: Chao Yu Message-ID: <55de7e3a-9c21-4601-6ee7-83ba97a2509e@huawei.com> Date: Tue, 10 Jul 2018 14:17:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180710033242.177557-1-drosen@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/10 11:32, Daniel Rosenberg wrote: > If we attempt to request more blocks than we have room for, we try to > instead request as much as we can, however, alloc_valid_block_count > is not decremented to match the new value, allowing it to drift higher > until the next checkpoint. This always decrements it when the requested > amount cannot be fulfilled. > > Signed-off-by: Daniel Rosenberg Good catch, thanks for the fixing. :) Reviewed-by: Chao Yu Thanks,