Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1378483imm; Tue, 10 Jul 2018 00:20:32 -0700 (PDT) X-Google-Smtp-Source: AAOMgpejnfMnGjo5m6P/h6IkyVii6CcYZ94xBO1+ba2UMcR5AdN1stLr7xrU6wgTOMs8oEHNxjnW X-Received: by 2002:a63:7a0a:: with SMTP id v10-v6mr21379924pgc.444.1531207232290; Tue, 10 Jul 2018 00:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531207232; cv=none; d=google.com; s=arc-20160816; b=cvpe0gLwdzamMoxZf2P14e1dxLaqj3X5ri+uj/8ZkcVrH1a/75JVA1zN9lYPnp7d0h czAPHzkCLq53LUb+YOJXh4sHGlAxVwJx8qgzVvih5N5PQKMGXpB1cJdyn2kFmWxpQwjX BhrlrlLgFQ0N1IWyYaJXerNE7h1JDPNReRm9MDmLe1Y1bXFxAnsquvkfObPnZ4miIlGn Yj+y6dXPLZ4/X0iwWwKeoaRqbjKPHjgd78VubKVGA0ITzg3lgVjzeuu7J0dz7XUEZX9W C8rmfakQZUhG4zslhg6H1VxPPLV1N3Vj8OYwgzyIRIeL7O+EftmrG01g/M5+GmgdrAoe P0bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Z2tYrbsLnuBADeDHMudGs5/rH24qfZ58NepYhlwmRiU=; b=iTIx94KxZdAZbtUpXxX/zU72LRP3lNia5r4LJKVR8pqsCtjppdrlbhl1+RhFjLu7KK GRAtqrvR/AWq2MYYR7Kge0U882DCRNFN1JMc1mkuGhEXHksEaIcFaLyBkoPCN1zgSXR/ XTiSsMac1ZBlIPFNO4pVZlv+1T38/qB1zNk4cLbGuxD0iakxhAx1C9q6YpYGGMvd5KYD HaVwLbkxzIe9ARcxWe032rNBUfD2zLOP2/gfldf3s226sTtwl98/RL57YHN2WTayqml1 QivktPMptZRzcgOM5o05u0T66e9EE4l2IYkppD8c2+p0Diq6/6ptHhZ8soPI/WAKuDiU mLng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pXgqJAVM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u22-v6si15781158plq.135.2018.07.10.00.20.17; Tue, 10 Jul 2018 00:20:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=pXgqJAVM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751305AbeGJHTg (ORCPT + 99 others); Tue, 10 Jul 2018 03:19:36 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:33878 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeGJHTe (ORCPT ); Tue, 10 Jul 2018 03:19:34 -0400 Received: by mail-wm0-f48.google.com with SMTP id s13-v6so11828114wmc.1 for ; Tue, 10 Jul 2018 00:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z2tYrbsLnuBADeDHMudGs5/rH24qfZ58NepYhlwmRiU=; b=pXgqJAVM41BYbIhjnqi6JV20t62AYiM4Lr6ZSx8rR769mpO/xHjAr8S8SnVj1fB5Wx eeacUBpbIbZVlWpa2Vj6J9/nEQE9U5l6KasQXZ9Fy4+GI1B5TQRXaGkpdgX4B+KAmt+V QkoIXL00NLUQikP3lscnT/0GAP8nUuH0zdDdAfdZEmBHxSTCKAjfMTAIY8iXszPhuQtB MuHwWamnY06M9FxpcqCTnp6Cti+3RSNpu0ohPigTNz0LQDs9eMKPNtOS4p9WA3hs2PuD gZvj49pXacpe/iXeq6K/aBzgdvwrCgRv5wF9XVUid3O0n5YvuvniZT85IlX0M0OJI0f8 reeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z2tYrbsLnuBADeDHMudGs5/rH24qfZ58NepYhlwmRiU=; b=BTzHP4bK/d5+X7gsc3WQh/rL3+n18eric48mXrNaRbwgV0gAcRGAKzcsit0U5fNwy8 7vOv+GhOk2N18vfv2/2wfeO+/tYUF6Rth4trgq9cgay2dzPFqalLsuiXP2ElcJQWngje Owk5sTpXxRwKVK5MphjI0VqBSYpI2A5ERG1QVDmEQwQP0dol8QuwlkTxd54DQLe4XBWp iPbIyhHbZoKDn7WSEt8Ecy40hN8xC6mfsCLARWAqtK0v5hbwDuz81BLnBcS6tDRjbuxO LPYBf9nT09ycimYWcW5/tm2hVb7QZcvmwhKfNzf1LP3mY+BJuC1zZei64ACIFkVMOum2 03rg== X-Gm-Message-State: APt69E18oQ2YlcsF9J5jpy9T5oa4sp0UHMv5Y7V0rcUzew9k9jeX0qz1 FjdiTRXJgSPc6T4uBnfrHLh+p6NqWud9nj5fhOQ= X-Received: by 2002:a1c:8a04:: with SMTP id m4-v6mr13551984wmd.137.1531207173578; Tue, 10 Jul 2018 00:19:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a1c:61c1:0:0:0:0:0 with HTTP; Tue, 10 Jul 2018 00:19:32 -0700 (PDT) In-Reply-To: <20180709122019eucas1p2340da484acfcc932537e6014f4fd2c29~-sqTPJKij2939229392eucas1p2j@eucas1p2.samsung.com> References: <20180709121956.20200-1-m.szyprowski@samsung.com> <20180709122019eucas1p2340da484acfcc932537e6014f4fd2c29~-sqTPJKij2939229392eucas1p2j@eucas1p2.samsung.com> From: Joonsoo Kim Date: Tue, 10 Jul 2018 16:19:32 +0900 Message-ID: Subject: Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc() To: Marek Szyprowski Cc: Linux Memory Management List , LKML , linux-arm-kernel@lists.infradead.org, linuxppc-dev , iommu@lists.linux-foundation.org, Andrew Morton , Michal Nazarewicz , Joonsoo Kim , Vlastimil Babka , Christoph Hellwig , Michal Hocko , Russell King , Catalin Marinas , Will Deacon , Paul Mackerras , Benjamin Herrenschmidt , Chris Zankel , Martin Schwidefsky , Joerg Roedel , Sumit Semwal , Robin Murphy , Laura Abbott , linaro-mm-sig@lists.linaro.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Marek. 2018-07-09 21:19 GMT+09:00 Marek Szyprowski : > cma_alloc() function doesn't really support gfp flags other than > __GFP_NOWARN, so convert gfp_mask parameter to boolean no_warn parameter. Although gfp_mask isn't used in cma_alloc() except no_warn, it can be used in alloc_contig_range(). For example, if passed gfp mask has no __GFP_FS, compaction(isolation) would work differently. Do you have considered such a case? Thanks.