Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1378774imm; Tue, 10 Jul 2018 00:20:54 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfknwp31a1x6wCuOxMWjknF7zMqbpLHX4080zVwXrtqDfab00VBuKoHADfOq9pbjWJLt6pJ X-Received: by 2002:a63:4506:: with SMTP id s6-v6mr22197814pga.422.1531207254503; Tue, 10 Jul 2018 00:20:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531207254; cv=none; d=google.com; s=arc-20160816; b=afZDV01ekVAewLAJO5l5d0HlDWGwdIxXOV6zWYV9+R/ZAicei6Ym6d4f43YCkos45h 7QkmPMoslAtPVduvYK3c8H2MQ+qnBGdqiov6ZwIfFgNjuzoVSlO1hfpAC9YOaVGKAfhc 2YRzNamZN3oRmG1BhOZq95JWfZhBkMKZ6XVDTEypXXUZDK4ujO9nfI8JPMJdu0/Sp5v4 I1if63bjDpG9NdbcV9dTDxu1lVgRZx2xF+5baB3sryiOAcHYiC8hpDHbfs4L791gNvg2 /tyZBrsrV+UilBQ+xzj5/5cCKJWYSdtqOsLvSOkGC4YqEhLfG7EHwMq2r1ucHAeuDE9E vDfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:arc-authentication-results; bh=k7IgjNfjGwFrLnx/eA6zSy/Bj0ChegBq9rqBz3nhrlk=; b=Dpl7/VneaQ0XejFCt+nhWXP6EmM/CD7oDZGKtCAbuUT9LkyOIIMBF0hBmUMZ1pcmBg 426RpDgoHf6vnEiC8m9yfjxywtT3CU/1YSfi7uGKv+jEZGzRb3Xi9tdUkCqCGGBQQoEN +Rd2qZf7ZIC1oxL4PIZVh6mZ1XJbhyzEGZdrQX3jATJIIcO2V6/EahSClCQD27/J6EF8 MU0QElWSu68FQ6owJ7WZpwji1qfFLw7Y/8TMC5dEqhsG6TjttEuxrGHCjPD2ZLcSd9AU kIgPkIZSHBMJvWOzia6w3Mfcs3NONVDrC/lG6lXvXjWTk/ND/gCysyNWHPhJF5EJasNa g/Vg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s126-v6si17456093pfc.222.2018.07.10.00.20.39; Tue, 10 Jul 2018 00:20:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbeGJHTS (ORCPT + 99 others); Tue, 10 Jul 2018 03:19:18 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:49732 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750998AbeGJHTR (ORCPT ); Tue, 10 Jul 2018 03:19:17 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 6488228DD2667; Tue, 10 Jul 2018 15:19:13 +0800 (CST) Received: from [127.0.0.1] (10.177.16.168) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.382.0; Tue, 10 Jul 2018 15:19:04 +0800 Subject: Re: [PATCH] net/9p/client.c: add missing '\n' at the end of p9_debug() To: piaojun , , , , References: <5B44589A.50302@huawei.com> CC: , From: jiangyiwen Message-ID: <5B445DE7.3070607@huawei.com> Date: Tue, 10 Jul 2018 15:19:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <5B44589A.50302@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.16.168] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/7/10 14:56, piaojun wrote: > In p9_client_getattr_dotl(), we should add '\n' at the end of printing > log. > > Signed-off-by: Jun Piao Reviewed-by: Yiwen Jiang > --- > net/9p/client.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/9p/client.c b/net/9p/client.c > index 5c13431..8bc8b3e 100644 > --- a/net/9p/client.c > +++ b/net/9p/client.c > @@ -1790,7 +1790,7 @@ struct p9_stat_dotl *p9_client_getattr_dotl(struct p9_fid *fid, > "<<< st_mtime_sec=%lld st_mtime_nsec=%lld\n" > "<<< st_ctime_sec=%lld st_ctime_nsec=%lld\n" > "<<< st_btime_sec=%lld st_btime_nsec=%lld\n" > - "<<< st_gen=%lld st_data_version=%lld", > + "<<< st_gen=%lld st_data_version=%lld\n", > ret->st_result_mask, ret->qid.type, ret->qid.path, > ret->qid.version, ret->st_mode, ret->st_nlink, > from_kuid(&init_user_ns, ret->st_uid), >