Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1379262imm; Tue, 10 Jul 2018 00:21:35 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdqAf14EJGrmah9zEPYv+fIrqs/vHHlj8Mor+72dC07IPh3lXx8amk7U2E1tUj+gkl17C8K X-Received: by 2002:a62:864a:: with SMTP id x71-v6mr24632306pfd.252.1531207295078; Tue, 10 Jul 2018 00:21:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531207295; cv=none; d=google.com; s=arc-20160816; b=Nzz+3TCbTbIkqoLJ/hJXCOa2RVe5qVPW3ksBd/5FQyPsOprGOFz29vhWRepQrPyFBY nbi3kEI4HgCZABuOf07qkyLFVLv6nidryHnagfZLyCQu1jpvby3ss0QbeqolvNSFpj7I JeJpPgAi8eCI+aDJkhXIT18XO/zs/LSFue8K3sUaIc5A0PEycsTpOdj1uRML6/XRa8hF pZFK2ABF3e8ycOWe9lZ5KxE1apw4qOb128KtyrPktHeh7gum9zdFUIsRJeBVtDs/aF70 cBW5aJ74MSc17UoQmlZ8PKuO+/V3WY9JdzhuyQRCTK1R0E6/PVfATvJf0jiNWdllKyou 69oQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=zgcSLD/+lrVmEfnEbVnW+CeQrfIULlPBhmZxFe9wZWk=; b=STtm7nfSB82/br/NMxL3CZSTDwj6Gmjv+BRzTDNJIVDvcHkw/frhrKRU1KcVefp0Xv txhhlOHY/8MBmm5ebvMHEk4uUOQ786B8AzIc2Zsz5/PePG6aF36xQSjWuKicXle0rhuB ri/JCj819X9ZtWEu2SM+rMaH83dfhJdik4nMYyMkQjP41P+FBE633MPpazECZcRjMROS WZpAyce5Bd9EHv/Ooetv/Xyx0qT/U9OwTsQzDr+Ikoe8K+e/XX+QXtQs5ESw6BQQVWsK P1o0C8iWbOiqgEt0Rd+uaqtBIJdHntGX+7MAbC+rRrjhXiH8XKmoW7oUxa+/etaZkWRy Tqmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7-v6si16827037pfg.308.2018.07.10.00.21.20; Tue, 10 Jul 2018 00:21:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbeGJHU3 (ORCPT + 99 others); Tue, 10 Jul 2018 03:20:29 -0400 Received: from www62.your-server.de ([213.133.104.62]:37204 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbeGJHU2 (ORCPT ); Tue, 10 Jul 2018 03:20:28 -0400 Received: from [78.46.172.3] (helo=sslproxy06.your-server.de) by www62.your-server.de with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.85_2) (envelope-from ) id 1fcmwh-0006SX-RQ; Tue, 10 Jul 2018 09:20:23 +0200 Received: from [2a02:120b:c3f4:b8b0:b5ea:3969:d380:aafd] (helo=linux.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1fcmwh-000Jgo-Ma; Tue, 10 Jul 2018 09:20:23 +0200 Subject: Re: [PATCH v2] samples/bpf: Fix tc and ip paths in xdp2skb_meta.sh To: Taeung Song , Alexei Starovoitov Cc: Jesper Dangaard Brouer , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180709175121.3355-1-treeze.taeung@gmail.com> From: Daniel Borkmann Message-ID: Date: Tue, 10 Jul 2018 09:20:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20180709175121.3355-1-treeze.taeung@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.100.0/24739/Tue Jul 10 06:45:06 2018) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2018 07:51 PM, Taeung Song wrote: > The below path error can occur: > > # ./xdp2skb_meta.sh --dev eth0 --list > ./xdp2skb_meta.sh: line 61: /usr/sbin/tc: No such file or directory > > So just use command names instead of absolute paths of tc and ip. > In addition, it allow callers to redefine $TC and $IP paths > > Fixes: 36e04a2d78d9 ("samples/bpf: xdp2skb_meta shows transferring info from XDP to SKB") > Reviewed-by: Jesper Dangaard Brouer > Signed-off-by: Taeung Song Applied to bpf, thanks Taeung!