Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Jul 2018 14:29:22 +0200
From:   Maxime Ripard <maxime.ripard@bootlin.com>
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     linux@armlinux.org.uk, mark.rutland@arm.com, robh+dt@kernel.org,
        tj@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
        icenowy@aosc.io
Subject: Re: [PATCH v2 0/4] sun8i: r40: add AHCI
Message-ID: <20180710122922.6sgmgfislqwhn3tt@flea>
References: <1531149658-27030-1-git-send-email-clabbe@baylibre.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vm7covlgenulwjwo"
Content-Disposition: inline
In-Reply-To: <1531149658-27030-1-git-send-email-clabbe@baylibre.com>
User-Agent: NeoMutt/20180622
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--vm7covlgenulwjwo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 09, 2018 at 03:20:54PM +0000, Corentin Labbe wrote:
> Hello
>=20
> With Moeicenowy's agreement, I have take leadership ot this patchset.
>=20
> There are no really changes appart renaming struct quirck to variant.
>=20
> Since the last serie is really old, I will answer comment here.
> The two regulator (1.2 and 2.5V) are not for the PHY since:
> - nothing in the schematic said that they are for the PHY, they seems
>   only for controller
> - all other AHCI driver use 5V for the target/PHY (vs 1.2/2.5 which
>   cannot be used for target)

That's a pretty bad thing to do, especially for old series. You just
dropped all the context that you reply to, and there's no way for any
reviewer to tell if your answers make any kind of sense, or addresses
any question one might have had.

> Furthermore, the AHCI binding support only one regulator per PHY, so
> using the "target" regulator is out of question for registring this two
> non-phy regulator.

Nothing is "out of question", we have the source code and can change
it if needed.

Maxime

--=20
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

--vm7covlgenulwjwo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAltEppsACgkQ0rTAlCFN
r3RDRBAAmTUyhlteXxldpaeQ/cpQVxaFTo2g/u+SluX8uvxkBIipigP6oJMZNfRN
likZ9EefsSR8xXjOh9IPQaGou75zwaD5rWjEZ0HcdpeNQvEaEXkROxXMpIlgSP62
I7WZ3NHbcUfKs1pPGsehsoSliwpvvQK3Yr43wW4o0xzII37v0btdZsd74fsIX9YC
S+P9UsISm5O0jWH4waoTJAyhV1HaHj8324GeDV14YbqyuNUmW6QH5n23KKg/KY0w
DjoArMKraErleto1tQZ2krA4S7Td09HnpOA2cqXeQU+bqzzCIu7V4hWXezs2rR0e
YNAwTPdKkp01qvE009OOOHmarFZ+nMlB0lpTIJzmKFyfL2VzRzwSzcW1OZW0S2hx
BPorL+N5DcvDF4GsUEx0AXq6R+7Pfd7Inkyp7dUptwqLkaq7JEz6rOdnFv+FV3mJ
g7i+2WkX9vKfw0uOU06m7RQBO8xi6EhlTyOiZ6Wjne+xyG5ivXVtubTRxWoi8PgN
xmUmjD5BKzgFvfzhKQaiIMAdDgWkXUsWLP6HDBr06PrMp4n9bqpIPPaWFDkqBKUK
BxrI6nMrmSKUQ9PC5IdXF8Pcdv9YpEMbm2MXfwV1t/CA43VGBah29OhhgDpp3u6m
rsuQJz3nVTezKNSm4Cpas3hbFHgrXgpGEHg/sVpBvO6CWJC4+iA=
=9xwj
-----END PGP SIGNATURE-----

--vm7covlgenulwjwo--