From: Rusty Russell <rusty@rustcorp.com.au>
To: Jamie Lokier <jamie@shareable.org>
Cc: Felipe W Damasio <felipewd@terra.com.br>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kernel/futex.c: Uneeded memory barrier 
In-reply-to: Your message of "Sat, 13 Sep 2003 20:02:42 +0100."
             <20030913190242.GC7404@mail.jlokier.co.uk> 
Date: Mon, 15 Sep 2003 11:36:36 +1000
Message-Id: <20030915054300.74AF72C061@lists.samba.org>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 924
Lines: 27

In message <20030913190242.GC7404@mail.jlokier.co.uk> you write:
> If _all_ instances in the kernel of
> 
> 	set_current_state(TASK_RUNNING)
> 
> can be validly turned into
> 
> 	__set_current_state(TASK_RUNNING)
> 
> it would be good to make the barrier in set_current_state() itself
> conditional on the state being state.

Or eliminate the macro altogether, and create set_current_interruptible()
and set_current_uninterruptible() which have the barrier, and let the normal
users do the assignment the way God intended 8)

In practice, those who care are using __, the rest aren't critical.

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/