Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: RE: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check
Thread-Topic: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size check
Thread-Index: AQHUF5W7AkhTBmuvJU2/fCjJwRzd7qSHRsSAgAFV10A=
Date:   Tue, 10 Jul 2018 15:55:32 +0000
Message-ID: <AM3PR04MB338B88A42C1B4802D832DCE945B0@AM3PR04MB338.eurprd04.prod.outlook.com>
References: <20180709150111.8875-1-ruxandra.radulescu@nxp.com>
 <20180709150111.8875-6-ruxandra.radulescu@nxp.com>
 <20180709192809.msmwmtmgj4yxrhme@mwanda>
In-Reply-To: <20180709192809.msmwmtmgj4yxrhme@mwanda>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a859a620-c449-4d52-e5b7-08d5e67d9171
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2018 15:55:32.7629
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1218
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Monday, July 9, 2018 10:28 PM
> To: Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>
> Cc: gregkh@linuxfoundation.org; devel@driverdev.osuosl.org; linux-
> kernel@vger.kernel.org; Ioana Ciornei <ioana.ciornei@nxp.com>
> Subject: Re: [PATCH 5/5] staging: fsl-dpaa2/eth: Remove Rx frame size che=
ck
>=20
> On Mon, Jul 09, 2018 at 10:01:11AM -0500, Ioana Radulescu wrote:
> > @@ -2385,6 +2365,12 @@ static int netdev_init(struct net_device
> *net_dev)
> >
> >  	/* Set MTU upper limit; lower limit is 68B (default value) */
> >  	net_dev->max_mtu =3D DPAA2_ETH_MAX_MTU;
> > +	err =3D dpni_set_max_frame_length(priv->mc_io, 0, priv->mc_token,
> > +					(u16)DPAA2_ETH_MFL);
>=20
> The cast was there in the original code so this is not a comment on this
> particular patch (which seems fine) but there is no need to cast.
>=20
> Generally it's best to avoid unnecessary casts.  As a human reader, I
> find the cast confusing.  It indicates that DPAA2_ETH_MFL somehow
> requires special handling.  Perhaps it's negative or we are trying to
> truncate away the high bits.  But neither of those things really make
> sense.
>=20
> From a static analysis perspective if DPAA2_ETH_MFL doesn't fit nicely
> then we would want to generate a warning.  But the cast explicitly
> disables the check.

I really don't remember why the cast was there in the first place.
It doesn't look like it's needed anymore, DPAA2_ETH_MFL has a
positive value (around 10K) that fits just fine inside a u16.

I see Greg already applied the patch, so I'll send a separate one to
remove the cast.

Thanks,
Ioana