Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Jul 2018 18:49:05 +0100
From:   Okash Khawaja <osk@fb.com>
To:     Daniel Borkmann <daniel@iogearbox.net>
CC:     Martin KaFai Lau <kafai@fb.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Yonghong Song <yhs@fb.com>,
        Jakub Kicinski <jakub.kicinski@netronome.com>,
        "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <kernel-team@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf 1/1] bpf: btf: Fix bitfield extraction for big endian
Message-ID: <20180710174904.GA3247@w1t1fb>
References: <20180709002202.019053555@fb.com>
 <20180709004002.440153594@fb.com>
 <20180709183236.r4b7gzmev5h4lcbw@kafai-mbp.dhcp.thefacebook.com>
 <58136182-0eb1-78c9-ceb9-402418c7d10c@iogearbox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <58136182-0eb1-78c9-ceb9-402418c7d10c@iogearbox.net>
User-Agent: Mutt/1.9.5 (2018-04-13)
Received-SPF: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2018 17:49:26.2678 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: bb09a44a-7db0-4988-3c42-08d5e68d7b54
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR15MB2507
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-07-10_06:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 10, 2018 at 10:21:02AM +0200, Daniel Borkmann wrote:
> On 07/09/2018 08:32 PM, Martin KaFai Lau wrote:
> > On Sun, Jul 08, 2018 at 05:22:03PM -0700, Okash Khawaja wrote:
> >> When extracting bitfield from a number, btf_int_bits_seq_show() builds
> >> a mask and accesses least significant byte of the number in a way
> >> specific to little-endian. This patch fixes that by checking endianness
> >> of the machine and then shifting left and right the unneeded bits.
> >>
> >> Thanks to Martin Lau for the help in navigating potential pitfalls when
> >> dealing with endianess and for the final solution.
> >>
> >> Fixes: b00b8daec828 ("bpf: btf: Add pretty print capability for data with BTF type info")
> >> Signed-off-by: Okash Khawaja <osk@fb.com>
> >>
> >> ---
> >>  kernel/bpf/btf.c |   32 +++++++++++++++-----------------
> >>  1 file changed, 15 insertions(+), 17 deletions(-)
> >>
> >> --- a/kernel/bpf/btf.c
> >> +++ b/kernel/bpf/btf.c
> >> @@ -162,6 +162,8 @@
> >>  #define BITS_ROUNDDOWN_BYTES(bits) ((bits) >> 3)
> >>  #define BITS_ROUNDUP_BYTES(bits) \
> >>  	(BITS_ROUNDDOWN_BYTES(bits) + !!BITS_PER_BYTE_MASKED(bits))
> >> +const int one = 1;
> >> +#define is_big_endian() ((*(char *)&one) == 0)
> 
> Also here, in the kernel archs provide proper definitions.
Is this the __BIG_ENDIAN #define or are there better ways to check that?

Thanks,
Okash