Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Jul 2018 14:04:15 -0700
From:   Paul Burton <paul.burton@mips.com>
To:     Serge Semin <fancer.lancer@gmail.com>
Cc:     Mathieu Malaterre <malat@debian.org>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>, okaya@codeaurora.org,
        chenhc@lemote.com, Sergey.Semin@t-platforms.ru,
        Linux-MIPS <linux-mips@linux-mips.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "# v4 . 11" <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] mips: mm: Discard ioremap_uncached_accelerated()
 method
Message-ID: <20180710210415.4uqstovovdfvxfup@pburton-laptop>
References: <20180709135713.8083-1-fancer.lancer@gmail.com>
 <20180709135713.8083-2-fancer.lancer@gmail.com>
 <CA+7wUsxDfBdiGt5tZ7dxb63oMd=3Ry4s1Xysed8RSHJi35=VxQ@mail.gmail.com>
 <20180710074815.GA30235@mobilestation>
 <20180710175940.rbjmdcpm54gfrael@pburton-laptop>
 <20180710191354.GA32182@mobilestation>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180710191354.GA32182@mobilestation>
User-Agent: NeoMutt/20180622
Received-SPF: None (protection.outlook.com: wavecomp.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2018 21:04:18.3898 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: be8a44ec-860f-4bf2-d776-08d5e6a8b3b0
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 463607d3-1db3-40a0-8a29-970c56230104
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR08MB4932
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Serge,

On Tue, Jul 10, 2018 at 10:13:54PM +0300, Serge Semin wrote:
> On Tue, Jul 10, 2018 at 10:59:40AM -0700, Paul Burton <paul.burton@mips.com> wrote:
> > However FYI for next time - you shouldn't really add someone else's
> > Signed-off-by tag anyway. The tag effectively states that a person can
> > agree to the Developer's Certificate of Origin for this patch (see
> > Documentation/process/submitting-patches.rst), and you can't agree that
> > on behalf of someone else. Generally a maintainer should add this tag
> > for themselves when they apply a patch.
> 
> I'm sorry if it seemed like I added Signed-off on your behalf.

That's OK, I didn't think you did it maliciously :)

> I thought the Signed-off also concerns the ones, who participated in
> the patch preparation. Since you suggested the design of the change,
> I've decided to put your name in the Signed-off tag. What shall I use
> in this way then?

In this case Suggested-by might have been a good choice. Reported-by is
also commonly used if someone reported a problem which you created a fix
for.

Section 13 of Documentation/process/submitting-patches.rst describes
these tags along with a couple others.

Thanks,
    Paul