Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Check jvmti_agent snprintf return value to avoid build
 failures with GCC-8.1.1
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com,
        namhyung@kernel.org
References: <20180710182716.21801-1-wcohen@redhat.com>
 <20180710225824.GA11928@krava>
From:   William Cohen <wcohen@redhat.com>
Message-ID: <c738c33d-660d-a57a-2e8c-439f12378b5b@redhat.com>
Date:   Tue, 10 Jul 2018 20:10:10 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180710225824.GA11928@krava>
Content-Type: text/plain; charset=utf-8
Content-Language: en-MW
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 07/10/2018 06:58 PM, Jiri Olsa wrote:
> On Tue, Jul 10, 2018 at 02:27:16PM -0400, William Cohen wrote:
>> Newer versions of GCC perform static analysis to determine whether
>> string truncation is possible with functions such as snprintf and
>> provide a warning if truncation could occur.  The make for
>> jvmti_agent.c uses the compiler option that treats any compiler
>> warnings as compiler errors.  For GCC-8.1.1 in Fedora 28 this causes
>> the build to fail.  The return value of the snprint is now checked to
>> ensure snprintf produced a NULL-terminated string.  If the string for
>> the path is invalid, the code does attempt to use the string.
> 
> hi,
> I posted fix for this recently:
>   https://lore.kernel.org/lkml/20180702134202.17745-1-jolsa@kernel.org/
> 
> it also covers the perf_regs.c, which was failing with gcc8 for me
> 
> should be pulled in soon
> 
> thanks,
> jirka

Hi Jirka,

Thanks.  I hadn't seen the patch, and this failing to build for the past week has been bugging me.  Glad to hear there is already a fix queued up.

-Will
> 
>>
>> Signed-off-by: William Cohen <wcohen@redhat.com>
>> ---
>>  tools/perf/jvmti/jvmti_agent.c | 7 +++++--
>>  1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/tools/perf/jvmti/jvmti_agent.c b/tools/perf/jvmti/jvmti_agent.c
>> index 0c6d1002b524..30f14eafe4b3 100644
>> --- a/tools/perf/jvmti/jvmti_agent.c
>> +++ b/tools/perf/jvmti/jvmti_agent.c
>> @@ -227,7 +227,7 @@ void *jvmti_open(void)
>>  {
>>  	char dump_path[PATH_MAX];
>>  	struct jitheader header;
>> -	int fd;
>> +	int retlen, fd;
>>  	FILE *fp;
>>  
>>  	init_arch_timestamp();
>> @@ -249,7 +249,10 @@ void *jvmti_open(void)
>>  	/*
>>  	 * jitdump file name
>>  	 */
>> -	snprintf(dump_path, PATH_MAX, "%s/jit-%i.dump", jit_path, getpid());
>> +	retlen = snprintf(dump_path, PATH_MAX, "%s/jit-%i.dump",
>> +			  jit_path, getpid());
>> +	if (retlen <= 0 || ((int) sizeof(dump_path)) <= retlen)
>> +		return NULL;
>>  
>>  	fd = open(dump_path, O_CREAT|O_TRUNC|O_RDWR, 0666);
>>  	if (fd == -1)
>> -- 
>> 2.17.1
>>