Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2300802imm; Tue, 10 Jul 2018 17:45:01 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd6SGYy8R9vZmquAT6SJcH+DS2vMI3uwOYWjcPPcW5zjX67KFhgQyEnPze5iaNY0n9LaSge X-Received: by 2002:a17:902:d711:: with SMTP id w17-v6mr26124879ply.200.1531269901398; Tue, 10 Jul 2018 17:45:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531269901; cv=none; d=google.com; s=arc-20160816; b=RPe3Kuer46cmnLrvOc9BCqNbIN/6DFSz1X9q4H0rSurEvzVJYIHPfusyDaE9phILvm tgCa1x7N5sSdXutOZhdbr5ug0cqQ+b2up9ymzABldQ44CBXE0P2Ek5iDV9aO/keEWWYF fhByig6MTDZCkjD6jm3KnQsoTNe/mKaoyY4FrrloIBlM1dxi4RxhTu4vw+HNlXk+uFlv 25T0Sd2n6s4eDlQRSKrfdubrcaSKKzbsdj7bb2fvyRJ2W8JE9H1OgRP5Qg/oyVhhykAx 3Fb2H3ReVXz5XLlEgJXolx5ZRfDu5BF3NMA75pu0EXJcKbvfyqnTpUn3wZBKDwrHwxYU qA1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:date:message-id:subject:from:cc:to :arc-authentication-results; bh=eraigBP9hdcXOLQNYgNAnT5fYg6Cfi1TVyZ5xPRgMNw=; b=Kdtm+3SW18kFer9JC0rPJnNX3cTW4zVuVkwSq+pkxs/UaYvnlXi3v4mdjIbzeYJdME 0Zd2iHbTzIq3uXIzwzXJ5wy2rub/hosfjDx+gkVmCT0QosqBrG/qgcHftRcErDqVKKGF XOFfY8Q6SsGrTT017RoOXerspvsbMDT6lSXs5fFpaSROCc7M8CJCYFbr9XODa+EHn1EY cFi+k4aKAh8oXXdimDJZPJrwBREZiRbBNcDmauA1jH04v3NxuiblKxHxI0skKtDRzxCc /wR/A8ygARKzbarQDU93te0shI74p+ciPPSqTI8U/Ge5UY2rUHQteHbeXfNGVe+v1DOj z0Zw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x24-v6si17742092pln.22.2018.07.10.17.44.45; Tue, 10 Jul 2018 17:45:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732301AbeGKApt (ORCPT + 99 others); Tue, 10 Jul 2018 20:45:49 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:9217 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732262AbeGKApt (ORCPT ); Tue, 10 Jul 2018 20:45:49 -0400 Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 18F96691CD984; Wed, 11 Jul 2018 08:43:59 +0800 (CST) Received: from [10.177.253.249] (10.177.253.249) by smtp.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.382.0; Wed, 11 Jul 2018 08:43:50 +0800 To: "akpm@linux-foundation.org" , , , CC: Linux Kernel Mailing List , , Jiangyiwen From: piaojun Subject: [PATCH] 9p/net/protocol.c: return -ENOMEM when kmalloc() failed Message-ID: <5B4552C5.60000@huawei.com> Date: Wed, 11 Jul 2018 08:43:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.253.249] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We should return -ENOMEM to upper user when kmalloc failed to indicate accurate errno. Signed-off-by: Jun Piao --- net/9p/protocol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/9p/protocol.c b/net/9p/protocol.c index 931ea00..4a1e1dd 100644 --- a/net/9p/protocol.c +++ b/net/9p/protocol.c @@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size) *sptr = kmalloc(len + 1, GFP_NOFS); if (*sptr == NULL) { - errcode = -EFAULT; + errcode = -ENOMEM; break; } if (pdu_read(pdu, *sptr, len)) { --