Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp2323110imm; Tue, 10 Jul 2018 18:18:08 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcnOs0zUkRqaZC8qGFP/eW8OlTRWBTyaVi08cpNG4uAMoexBmEV7GJNrh95yAoABbcmB3om X-Received: by 2002:a17:902:6f02:: with SMTP id w2-v6mr26196298plk.216.1531271888017; Tue, 10 Jul 2018 18:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531271887; cv=none; d=google.com; s=arc-20160816; b=aAuSz6JJji7j60yisRJHuV0SPizmWW/0SLpSCMQDE5dCmr5LWPoY5pR/QHLBaaf6Bd tqy0K3KDAmplsa4xl/7Eiz/K1aHH/cbjH7oMrrPPk1j6AT7UYbMK24UgTRDZ9ehq2ufu OaR9LrQ48k6PqwgB0dyyRRdgxFZ0Y5PVMPGdFJXwSXh0hakZbIj/wNtGjdEH9FYc7yGM 6fgE2DtqZ4qwMyXbkOXVvrGs3a3vxBqr9dJJ39gEUkCvFUibDs0Ld+sPM7aNBN1THJzi 0oNF0hnI1poNgULaFZjRhgG/rLhdux1CJHXyenxnAScvi3jk20fvLPOyZYj1DbD7q41Y p2jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=2EEv4TKOHky87J/DrGS9VQCs5oPv6TxwnEWJYWSHmt0=; b=wsMaCZADhYb6UmLsrvb4jS6JGFyalxmNsYlG6OCjkvmb71+BkliFS6kt/HbL/jiZDb Dw6ncXV63KERJcTwOBczn4kyxFqSLONmVmf5rntRReKn3/X1hfuaT9K5AozfHIMeacVL Xq+JeAuC2O4UwEjVOiQsgkb/HvnqtsZSt3N4q94CkJOESZw1Wmkn7qkqKGOLbm8LB/pH mN1aZe9A8Anj44q1VBuP7LvN0zV53Qs0Ilz+Cu6Kz33bXBPhNRIH36UpZVLVqpRV1i50 mn5e7xRHsgp0DtO2j7oYFLNmisIRvWGvBzZkBRXiSDcKJYK8DOjv5kh8q5eyxq8jKABf h8dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@onstation.org header.s=default header.b=htruyohU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31-v6si17994549plj.216.2018.07.10.18.17.52; Tue, 10 Jul 2018 18:18:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@onstation.org header.s=default header.b=htruyohU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732425AbeGKBSz (ORCPT + 99 others); Tue, 10 Jul 2018 21:18:55 -0400 Received: from onstation.org ([52.200.56.107]:37626 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732304AbeGKBSz (ORCPT ); Tue, 10 Jul 2018 21:18:55 -0400 X-Greylist: delayed 448 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Jul 2018 21:18:54 EDT Received: from xilitla.hsd1.wv.comcast.net (c-98-236-77-125.hsd1.wv.comcast.net [98.236.77.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 795E2149; Wed, 11 Jul 2018 01:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=onstation.org; s=default; t=1531271385; bh=GDpYeHMpP2ydMGRhtax3WCIMhYFicwVrzCcXDvD5Yls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=htruyohUx6k2Lugx8/bNuxHm/RNqb38nmsRDgkcP4wZ4H2NH4i/PbJN8fdGxJOGPQ RsBp2NhCda3TWxX7q6DT/0emzSD91wDM1VXYlR12AWVnfopLbW1L/KfJ2exiwj/CDJ EIexM5QfFiCjtzbNyAGLrwMu/lr4QygYzRMgEak4= From: Brian Masney To: jic23@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, andy.gross@linaro.org, david.brown@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org Cc: jonathan@marek.ca, jmaneyrol@invensense.com, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, mkelly@xevo.com, fischerdouglasc@gmail.com, bshah@kde.org, ctatlor97@gmail.com, masneyb@onstation.org Subject: [PATCH 1/3] iio: imu: mpu6050: add support for 6515 variant Date: Tue, 10 Jul 2018 21:09:30 -0400 Message-Id: <20180711010932.20313-2-masneyb@onstation.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180711010932.20313-1-masneyb@onstation.org> References: <20180711010932.20313-1-masneyb@onstation.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch adds support for the MPU 6515 variant. Confirmed that the driver functions correctly on a LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney Signed-off-by: Jonathan Marek --- This is a variation of Jonathan Marek's patch from postmarketOS https://gitlab.com/postmarketOS/linux-postmarketos/commit/b8ad1ec1859c8bbcbce94944b3f4dd68f8f9fc37 with the following changes: - The driver was previously throwing a 'whoami mismatch got XXX' error. Corrected ordering of hw_info variable to match the index of the inv_devices enum. The mpu6515 needed to come after mpu6500, not mpu6050. - Removed regulator code. See next patch in this series. I got confirmation from Jonathan M. that it was ok for me to submit his patch upstream with these changes. Jonathan C.: I assume that it is ok for the device tree binding documentation to go through IIO? If not, I can split this out into a separate patch if needed. Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt | 1 + drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 6 ++++++ drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 5 +++++ drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h | 2 ++ 4 files changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt b/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt index 5f4777e8cc9e..b7def51c8ad9 100644 --- a/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt +++ b/Documentation/devicetree/bindings/iio/imu/inv_mpu6050.txt @@ -6,6 +6,7 @@ Required properties: - compatible : should be one of "invensense,mpu6050" "invensense,mpu6500" + "invensense,mpu6515" "invensense,mpu9150" "invensense,mpu9250" "invensense,mpu9255" diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index de68e83fc52d..12c1b9507007 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -103,6 +103,12 @@ static const struct inv_mpu6050_hw hw_info[] = { .reg = ®_set_6500, .config = &chip_config_6050, }, + { + .whoami = INV_MPU6515_WHOAMI_VALUE, + .name = "MPU6515", + .reg = ®_set_6500, + .config = &chip_config_6050, + }, { .whoami = INV_MPU6000_WHOAMI_VALUE, .name = "MPU6000", diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c index 495409d56207..dd758e3d403d 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c @@ -174,6 +174,7 @@ static int inv_mpu_remove(struct i2c_client *client) static const struct i2c_device_id inv_mpu_id[] = { {"mpu6050", INV_MPU6050}, {"mpu6500", INV_MPU6500}, + {"mpu6515", INV_MPU6515}, {"mpu9150", INV_MPU9150}, {"mpu9250", INV_MPU9250}, {"mpu9255", INV_MPU9255}, @@ -192,6 +193,10 @@ static const struct of_device_id inv_of_match[] = { .compatible = "invensense,mpu6500", .data = (void *)INV_MPU6500 }, + { + .compatible = "invensense,mpu6515", + .data = (void *)INV_MPU6515 + }, { .compatible = "invensense,mpu9150", .data = (void *)INV_MPU9150 diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h index de8391693e17..e69a59659dbc 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_iio.h @@ -71,6 +71,7 @@ struct inv_mpu6050_reg_map { enum inv_devices { INV_MPU6050, INV_MPU6500, + INV_MPU6515, INV_MPU6000, INV_MPU9150, INV_MPU9250, @@ -256,6 +257,7 @@ struct inv_mpu6050_state { #define INV_MPU9150_WHOAMI_VALUE 0x68 #define INV_MPU9250_WHOAMI_VALUE 0x71 #define INV_MPU9255_WHOAMI_VALUE 0x73 +#define INV_MPU6515_WHOAMI_VALUE 0x74 #define INV_ICM20608_WHOAMI_VALUE 0xAF /* scan element definition */ -- 2.17.1