Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] 9p/net/protocol.c: return -ENOMEM when kmalloc() failed
To:     piaojun <piaojun@huawei.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        <ericvh@gmail.com>, <rminnich@sandia.gov>, <lucho@ionkov.net>
References: <5B4552C5.60000@huawei.com>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <v9fs-developer@lists.sourceforge.net>
From:   jiangyiwen <jiangyiwen@huawei.com>
Message-ID: <5B455C87.6090507@huawei.com>
Date:   Wed, 11 Jul 2018 09:25:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <5B4552C5.60000@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018/7/11 8:43, piaojun wrote:
> We should return -ENOMEM to upper user when kmalloc failed to indicate
> accurate errno.
> 
> Signed-off-by: Jun Piao <piaojun@huawei.com>

Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com>

> ---
>  net/9p/protocol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/9p/protocol.c b/net/9p/protocol.c
> index 931ea00..4a1e1dd 100644
> --- a/net/9p/protocol.c
> +++ b/net/9p/protocol.c
> @@ -156,7 +156,7 @@ static size_t pdu_write(struct p9_fcall *pdu, const void *data, size_t size)
> 
>  				*sptr = kmalloc(len + 1, GFP_NOFS);
>  				if (*sptr == NULL) {
> -					errcode = -EFAULT;
> +					errcode = -ENOMEM;
>  					break;
>  				}
>  				if (pdu_read(pdu, *sptr, len)) {
>