Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp655imm; Tue, 10 Jul 2018 19:29:25 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe3OEdMqFb3+qCzWxXqDMBCOQ60WhRguMNtuzpzcDvHCxDpiW6uEoVU0kobcTSiNl2z1f2N X-Received: by 2002:a65:5c42:: with SMTP id v2-v6mr18695052pgr.224.1531276165379; Tue, 10 Jul 2018 19:29:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531276165; cv=none; d=google.com; s=arc-20160816; b=nRoiZKeJnp57kYcTnJkKTonHobt6bqeQUV4MTSiOGvUuLmUX5St9oJg4zdnlZgujN3 w0BrzfNEU/GIqfAY24eBsRTglqYJhrwCxiErRt7PwjtI2K6rdHBz774Ql9MrNI4BwtFM +ZujOpJJHELgfbEyVCDdzL8XE6aFXaDjosBR4bnUUKpvzZKMjOyMtffrt4huX7f/RB5D VTUQCZUXPvteIWmG320La0F3F7u3WizyKYxRxxrT/vOit045KbYgdAupq+Qcfb5n/jgQ WPiOdxh0Z1zRa5+bQtJCTvlxBL7SBGjqWqR6GZNUtWk87xYqekWzCoh51xXoWOTg94vk M8uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=kYuX8bix92fhp4bpZoQ43QHgdf5akS9zA9o5/pD5I6w=; b=G2YmvocorriAFbt9aQOD+/XS6aJ/+zVKPwWIfrQ2HrSZ/Yod4BvmPJ6khmSuIwsCr/ zV8EMGNDsKlydE7WcJhMBWh3Qeq+OYsXXFJARFytu3O40v9rdzsEforxfJjhNpY0onAZ hY4ehzxaE9EOiHDvEGcO264fdSEZRKmnFRkVxKYwpFgdBtTClQr8ipIFlNISxQPxrk6S PSKaLi9BryB0nZBlxTDUNluiXuZj6q0vesY1FdLc6UQ+goklLznF7imyuugH0FEx66jU 94qjDMggSJyOtqVP0GxFIQpMDk0UhYjFD6H8amvxJNW8p88HaZndkPq578VBaAK+u6Sn JcBQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2-v6si17847549pgm.288.2018.07.10.19.29.10; Tue, 10 Jul 2018 19:29:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732509AbeGKC3d (ORCPT + 99 others); Tue, 10 Jul 2018 22:29:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:24665 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732287AbeGKC3c (ORCPT ); Tue, 10 Jul 2018 22:29:32 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2018 19:27:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,336,1526367600"; d="scan'208";a="71744470" Received: from debian.sh.intel.com ([10.67.104.228]) by orsmga001.jf.intel.com with ESMTP; 10 Jul 2018 19:27:33 -0700 From: Tiwei Bie To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, virtio-dev@lists.oasis-open.org Cc: wexu@redhat.com, jfreimann@redhat.com, tiwei.bie@intel.com Subject: [PATCH net-next v2 0/5] virtio: support packed ring Date: Wed, 11 Jul 2018 10:27:06 +0800 Message-Id: <20180711022711.7090-1-tiwei.bie@intel.com> X-Mailer: git-send-email 2.18.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello everyone, This patch set implements packed ring support in virtio driver. Some functional tests have been done with Jason's packed ring implementation in vhost: https://lkml.org/lkml/2018/7/3/33 Both of ping and netperf worked as expected. v1 -> v2: - Use READ_ONCE() to read event off_wrap and flags together (Jason); - Add comments related to ccw (Jason); RFC (v6) -> v1: - Avoid extra virtio_wmb() in virtqueue_enable_cb_delayed_packed() when event idx is off (Jason); - Fix bufs calculation in virtqueue_enable_cb_delayed_packed() (Jason); - Test the state of the desc at used_idx instead of last_used_idx in virtqueue_enable_cb_delayed_packed() (Jason); - Save wrap counter (as part of queue state) in the return value of virtqueue_enable_cb_prepare_packed(); - Refine the packed ring definitions in uapi; - Rebase on the net-next tree; RFC v5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wrap counter; RFC v3 -> RFC v4: - Make ID allocation support out-of-order (Jason); - Various fixes for EVENT_IDX support; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_packed_init() out of uapi (Jason, MST); - Merge two loops into one in virtqueue_add_packed() (Jason); - Split vring_unmap_one() for packed ring and split ring (Jason); - Avoid using '%' operator (Jason); - Rename free_head -> next_avail_idx (Jason); - Add comments for virtio_wmb() in virtqueue_add_packed() (Jason); - Some other refinements and bug fixes; Thanks! Tiwei Bie (5): virtio: add packed ring definitions virtio_ring: support creating packed ring virtio_ring: add packed ring support virtio_ring: add event idx support in packed ring virtio_ring: enable packed ring drivers/s390/virtio/virtio_ccw.c | 14 + drivers/virtio/virtio_ring.c | 1365 ++++++++++++++++++++++------ include/linux/virtio_ring.h | 8 +- include/uapi/linux/virtio_config.h | 3 + include/uapi/linux/virtio_ring.h | 43 + 5 files changed, 1157 insertions(+), 276 deletions(-) -- 2.18.0