Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp6116imm; Tue, 10 Jul 2018 19:37:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeNZu6ZlREY4yso39OOXUJiNDZJQHwTXZBqUbgIIfUhZSgNWuhHS3+7QYYCPCYR25WDHk5A X-Received: by 2002:a17:902:48c8:: with SMTP id u8-v6mr27062166plh.152.1531276632064; Tue, 10 Jul 2018 19:37:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531276632; cv=none; d=google.com; s=arc-20160816; b=WnhnzsNnzfsmwRQtnQLv14RsdsVer6g3sU6JRcDK7zpAR5TdSIHxDm2jFwwt+zSg0R y8TRPE6yNcA1j/hwyoG0wy5cyKPjBRL7Vtx7l4E4rIHuVD1bAM55APv6h+gRpPxH0Xm0 knf8ZG3hIGA8BZWNPl6JRPrvgwdtTaIuRTIYxrd9QqIBmT4LWDlXZofetVTHe9iaQDmV g7Crf3QbRdQkenG9j0MyMRtRgxLXweDBu/1DPufDlVAkDwSFe5VPiEXuHncSnySZlSeZ OkwiNK4joXYyypsAsapub5NSJ/y6GoULmHA6WhQ0NZj0sns+IybDiytIvL4g0Vr3I8jM +J/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=hSkTdZN7Xmpzr9NJYyRZ147fF8bi/7NCm2Gk9OhkVF0=; b=sueZzNSlPm6f6Jvs8WKJdjdMf+roA5dEz4aIDPrlJQz/6lfPMPz9AR4SSG8Wf/Wcy7 Mm3EJl6ukRegIQe/RQDzZmMS+u86GnFhPlHKreDueFwi8t+pN03X0u//FTOJlTbEVZQS /ZLFdLuzCsgHtZwRzDlFykDLhjiE/LD+ecERPEeAKvqPDrOo4rV1GpC6j9P+LDC+zZhz 2lPdFCfS34L4D3mtUnLqmUTbA7qV0wkFgm67TcG67J//iiB8QWLp8j8+ceLALsnd4oOd 0pZez4zkOCjRLDBHxHQ6PuBGmvDT5FRtv2ctTVWR9pJ8ay9j5rC6WzI8NGWxv8weA+BK dVqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=GGAOafcY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m62-v6si19391391pfb.127.2018.07.10.19.36.56; Tue, 10 Jul 2018 19:37:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=GGAOafcY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732415AbeGKChe (ORCPT + 99 others); Tue, 10 Jul 2018 22:37:34 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:54482 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732277AbeGKChe (ORCPT ); Tue, 10 Jul 2018 22:37:34 -0400 Received: by mail-it0-f65.google.com with SMTP id s7-v6so1546288itb.4; Tue, 10 Jul 2018 19:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hSkTdZN7Xmpzr9NJYyRZ147fF8bi/7NCm2Gk9OhkVF0=; b=GGAOafcYy92lLN0fgDxQ84UJo/thqE4Z0TD7K121/osecxtkMrS2DTv1W/93e3iQjR XqqnvPw4jqeQ032WMFWsyguZ5i1sX4+HEVtTB+T7fDRQyabYvPgkHoxlQlJESfZZNlfH MbVhrmexEX2scpT/xpwfPbRb0wNDy/mtxkS/s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hSkTdZN7Xmpzr9NJYyRZ147fF8bi/7NCm2Gk9OhkVF0=; b=Ih2Tzm71gEgxBJbqEF2w8GZGLcRKdzyeOAF70mQCcRbgGNOMyIkQe/VjeS2vAwYlYJ wLSU+owJwmAusFNDTR2EoI4CObAZTKgBCXCCGbxPKIFRzQMF6pvAGyRb06/h5thhLtAm +Mk6MXW7QOD+JFQjErqQNXwalC/p1BowTdP7s/qsG348T9Ou9tHGFfT38j0gnAJR5Jqr XSsrTwQBJDLDV/UOenFcOj1uvqGRSU4IhEPrz/e3Jpdie4c3Vv2QeK3mvzY6h9fRb8uT uqBihMl0jcSH8lAC4TJlxR4zw7C4rGwjPx64sc6jNdylCxz/38vq6jXmWvNkj9k1t36g TOYA== X-Gm-Message-State: AOUpUlFCi1N/FHHJUVXpxfODu7XKsvLNnm8lpCAkPl2NFLHrvNS/oNl0 Mn9CxJ3e5SMOqB6V6X9jiBWMVYHxyWR3CM+2Ei0wjw== X-Received: by 2002:a24:5002:: with SMTP id m2-v6mr11047959itb.16.1531276534512; Tue, 10 Jul 2018 19:35:34 -0700 (PDT) MIME-Version: 1.0 References: <20180711021136.GN30522@ZenIV.linux.org.uk> <20180711022206.12571-1-viro@ZenIV.linux.org.uk> <20180711022206.12571-4-viro@ZenIV.linux.org.uk> In-Reply-To: <20180711022206.12571-4-viro@ZenIV.linux.org.uk> From: Linus Torvalds Date: Tue, 10 Jul 2018 19:35:23 -0700 Message-ID: Subject: Re: [RFC][PATCH 04/42] make get_empty_filp() to call file_free_rcu() directly To: Al Viro Cc: linux-fsdevel , Linux Kernel Mailing List , Miklos Szeredi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This one looked odd to me. Then I saw 5/42, and it made more sense. I think the explanation is a bit misleading. Technically correct, but not *why* you did it. Linus