Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp10533imm; Tue, 10 Jul 2018 19:44:40 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdfyHOsaUoE+v6ejMWHHzxA6ykt/MOr69GDw2Xe7sTmbp7NXFErODoRniLERkU01fFaobhG X-Received: by 2002:a62:4808:: with SMTP id v8-v6mr28224326pfa.89.1531277080644; Tue, 10 Jul 2018 19:44:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531277080; cv=none; d=google.com; s=arc-20160816; b=J1Rm9zkYOUCGz8vDQULu9JPqBAJAcy6JLFi5e4/DIfJRBmWQgdR0BylOUB0v/63iWb vK4RWKvEuORhtL/bZZ67yvq67NdtKSu/41XGe+f1EmIir2vRuFKCtS9QRa35D+tKzA8w 9xxZuj6X/gRLYi20nxlH7Xm9PyP6O4WG4LBfzYZA44uH+Gpp0CRrmwhZE62p7KsR/TBU E9HC4RYuQ/1JTLHthTwEtC3UhcyYsuuA2gxiEaDG4RCXkN1qW4aa3mCy/NWHuiOtvuhQ e3Z31nOcsJ+DtZIk7tkLr5xgX7MnGkxZnScg5dNlCChMBaXDfePrc7eHRz+R9f0/BXJV jXsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=ZukwN4vrViOTT8vC/I0SPmvN+BIN00FmcKzdRJOwpRc=; b=MO9IYkqR1k5GvfI2T0662UMGU2zOV0TuxlS2faK7xwyK3dosGjpaYlGLS/eEvG0iRc n4XZDbxsj6bpfnBIktAIquSMgKUN0n2T6KoCbZIJp9VYDPpvqJCQsAx1Sh3WYxd0DWy4 Bd8/fYs3l4MrPsLebCBNRaW7fF4e7b/hMHSLOWP/Gs4vgU4ShJJT10WxAIrPmWUgc12v zrgMO1msemortSg9+POUKn7ksjafiX1Nxx3oyrS88NhHn5+XzyKq0IicJdehr3ClbI+/ Tiask3jvCaoL/pGWPru6n8GcSzbnnN//IJnwqDc1kxczxZZ7sd5QsNi84OocPB6sO8o1 2PIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e2-v6si17637526pgl.4.2018.07.10.19.44.25; Tue, 10 Jul 2018 19:44:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732361AbeGKCpu (ORCPT + 99 others); Tue, 10 Jul 2018 22:45:50 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:47108 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732277AbeGKCpu (ORCPT ); Tue, 10 Jul 2018 22:45:50 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fd56a-0003so-8p; Wed, 11 Jul 2018 02:43:48 +0000 Date: Wed, 11 Jul 2018 03:43:48 +0100 From: Al Viro To: Linus Torvalds Cc: linux-fsdevel , Linux Kernel Mailing List , Miklos Szeredi Subject: Re: [RFC][PATCH 04/42] make get_empty_filp() to call file_free_rcu() directly Message-ID: <20180711024348.GP30522@ZenIV.linux.org.uk> References: <20180711021136.GN30522@ZenIV.linux.org.uk> <20180711022206.12571-1-viro@ZenIV.linux.org.uk> <20180711022206.12571-4-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 10, 2018 at 07:35:23PM -0700, Linus Torvalds wrote: > This one looked odd to me. > > Then I saw 5/42, and it made more sense. > > I think the explanation is a bit misleading. Technically correct, but > not *why* you did it. Probably should fold these two together, now that reordering has brought them next to each other (originally there used to be several pieces in between)...