Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp248743imm; Wed, 11 Jul 2018 01:33:13 -0700 (PDT) X-Google-Smtp-Source: AAOMgpelEAriN0KqU2gi3JLKtxeGfVi5+GqfPr8LrwaMWoEMpfkaDVu/deiXnBAIYt/lAfYnOqw/ X-Received: by 2002:a17:902:7481:: with SMTP id h1-v6mr28458953pll.183.1531297993033; Wed, 11 Jul 2018 01:33:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531297993; cv=none; d=google.com; s=arc-20160816; b=Psp/vN7g30du/s7JVHp65ox9ORf19bnxWU5IFrMnpoLMDu2axflujZUe3vF1tuIivl nGx+Q9BS3i29oDgcXimL/a5ULNEeUMX5pa3QpSTwdlEPvmZiWjMlLLnrMpIkZ8DSpl34 be7X6kxT7Ob3DLLxQasvRWv0D9jSr6tiuqB4ce6Ue83/qQx2ST6u+vzjkh0pCI0tsXuU 1V2uAUG7XEwNEsJ9I1ql+XrKd4vK1RKDh5T9IlpqpxWtQlwXiVxM3g0rRzqOJfQ6/vmU v3MwLoIdFgb88w/SMqf3DsF/y3k/qBX7lyfvfisuDYZUS6GPqCmrqrZ8jyLqY7SbtmKL m1XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=myz9PZz0JU4DyqQI42pxLu5+BUUW+GEdx5B8gXjLFPQ=; b=B2oUYSRs1JoOxRkhbL0hqLFt8wzZZZix+lNOeBF17bgq09NGIPe+ojgFjopT8GtE0Q /wIy1UX/CJ8G5z9bNWuL3Am94xpsjaPLwgEIxUWZWVKVbDh9+NzqoZnJVZI1MNPpUQ+S ZFkkkmBLPYo6ruZklYRNxRkML4MsebXBjsho2GRj9uq33fqDdnBbxw6Nbi45P8ryENNo plfGFYHKBPL5FqyvyC0PBPi9wJIb1SfoaSQWrYBw+IyEeAeo56w9iOGXw/FhfvNskZC4 Fv0czsm05yZxd0SjuXyJ2VCtLIZC3cjf/Hd3+3J9PQmeTBhCe1QyuOwNwNY+4W+Qj5Q9 yN/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lZDqIgAC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x127-v6si17544027pgb.618.2018.07.11.01.32.51; Wed, 11 Jul 2018 01:33:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=lZDqIgAC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732340AbeGKIfX (ORCPT + 99 others); Wed, 11 Jul 2018 04:35:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37963 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726664AbeGKIfX (ORCPT ); Wed, 11 Jul 2018 04:35:23 -0400 Received: by mail-wm0-f67.google.com with SMTP id 69-v6so1590894wmf.3 for ; Wed, 11 Jul 2018 01:32:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=myz9PZz0JU4DyqQI42pxLu5+BUUW+GEdx5B8gXjLFPQ=; b=lZDqIgACMmpwyYU+uFxP0K/PZPFxYGVAElN9DPr0kdNPnUkPXmc0QtqS7h8azaC+UO I6TsHyqRLWUhGyBb5FoqaeYF1kQdk9/vbYpAfqAYvEDmm1SeJrX6boV1JZJVudLxM5HZ yfduOsHNS1ARO4XpUHdLizC1wwYDw5E3AckySxbqErVEEYCg8X8HNLcULI+68507O1X6 cHa5ZQgEU64IJ4Ul3hTFMU4BN7jnoRlvGbRGRXsKwu+4cBB+5qrt0lpyvV2jNTXh/G3p 5A6v+SnoBi2ezItTRA25s7AIQvM6344iF6mEHXTgsZ3Z+7IBCGCeBbDxjkkT6sZbpet6 O7og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=myz9PZz0JU4DyqQI42pxLu5+BUUW+GEdx5B8gXjLFPQ=; b=Zsk3QSeKMpWd0FEeDoYEeEYOYKYjsmSeD8jBQUtsATBZq3E5XfgUsKjkoWd9OFiYD1 PbkkzJw4ACYEzPc0Logc2e4L0ddffdg2o1WNYepfnnnNkTVNeCCebtGFHWOeePutcg7/ LtwZO1XVWm46gitsh2PH/6GedJvZHE1CiqEDDU9pNTdPJzlPijgSomeY7dM3rmwBAUIN f48jhGHLRN2mhRkdMQjcMjYC70SQ6LR2Maw+gyA4JC/0Px6QbbnjNsypVcwW6qUytWd1 QXYS7RP3KotjbawJ15JwVsGy5Gzcgs780i4+zWdpmvuo7a3ecyH20EU/cKzR4uoK1oLM OIuQ== X-Gm-Message-State: APt69E3PJS61zSabcygDjqexSfARih2g5460ucyOWY/t1+uQlMfMRFQ3 fvRoIqtdW2OOaqqMsV2z+PmiYw== X-Received: by 2002:a1c:f009:: with SMTP id a9-v6mr17570014wmb.104.1531297932860; Wed, 11 Jul 2018 01:32:12 -0700 (PDT) Received: from localhost.localdomain (141.pool85-51-114.dynamic.orange.es. [85.51.114.141]) by smtp.gmail.com with ESMTPSA id h5-v6sm8206277wrr.19.2018.07.11.01.32.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 11 Jul 2018 01:32:12 -0700 (PDT) From: Jorge Ramirez-Ortiz To: jramirez@baylibre.com, jic23@kernel.org, lorenzo.bianconi@redhat.com Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: imu: st_lsm6dsx: irq not handled unless data pushed to buffers Date: Wed, 11 Jul 2018 10:32:08 +0200 Message-Id: <1531297928-3824-1-git-send-email-jramirez@baylibre.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently IRQ_NONE is returned only when there is no data on the fifo. When there is no data on the fifo the driver can not push to the buffers and therefore user space readers polling for data available will not be awoken and continue to wait. This commit just extends the same semantics to fifo read errors. Signed-off-by: Jorge Ramirez-Ortiz --- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c index 4994f92..4959923 100644 --- a/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c +++ b/drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_buffer.c @@ -472,7 +472,7 @@ static irqreturn_t st_lsm6dsx_handler_thread(int irq, void *private) count = st_lsm6dsx_read_fifo(hw); mutex_unlock(&hw->fifo_lock); - return !count ? IRQ_NONE : IRQ_HANDLED; + return (!count || count < 0) ? IRQ_NONE : IRQ_HANDLED; } static int st_lsm6dsx_buffer_preenable(struct iio_dev *iio_dev) -- 2.7.4