Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp257010imm; Wed, 11 Jul 2018 01:44:28 -0700 (PDT) X-Google-Smtp-Source: AAOMgpd3zLrR+l3QmQoWFiJEUuzFofHNdiU7DR3/NliRRj1KRzzNCiix9WHjLZM5IhjadglYsb4M X-Received: by 2002:a63:1844:: with SMTP id 4-v6mr20280484pgy.313.1531298667982; Wed, 11 Jul 2018 01:44:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531298667; cv=none; d=google.com; s=arc-20160816; b=rpKnlOekWr3DXLyjA44VwmPEgT5o113m72vuMvjiWpWA0W2uwhbnzp5Am2Ba240gSM G7qvZIUliAm38C3bvvGYsVL81lPhWkqR17NnaFprjK7S0tiKRmm++EnlsbG2GaCmujPZ jmjt1//5kltuuZ9xbPechAQEtj8l5lCHwQS2LBJedPx3dP93QgKkuXXuYB0dtPmAOzU0 59vMYkApkpcwuETdMjvNNTOPV5UzhUlWGgSbKhWHvZY86UZczf8dx3TzmDEwCzUr+q1/ twtO1oh1bf6C2JZq4nwH1PlYOLeS5HFZdY7zQK5Fpf84pGWXHIHqll4fKg0jXYxwm5sE Ipjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :arc-authentication-results; bh=eoa31xvtpOCIYgYYzAu9UhIKRMiSmDRhNYMoSYEf8eQ=; b=bdLSJvH8GHZaYEDsCk4ovEGD3aQNfxm1IK2qM2yh2fWoXSMqQW/yTCNwv14uNYfqE0 ooVe7QfOfkyr8im+pCseVxahYXMfNtRyCQE7V5V4f3PaEXQDKxU8xbrX0XoEBKdHvQB1 Gt2BG1tnSoPcxR1U6SXCWEMbHuX0lnziXVlAKFeeMmkcXqhIG8RHXjOgnsLdad5N886T L5s89he1SGIDzqsmvZtbxY64aEWtEVd/uqdhY8NYrvxl3Bh1cQMizx/RG/OevlH1Xarj IrXZDEbC1o+fqwgfpxoO/0ZM+DCMoFcAAkaUK6T8JRTDiCpi7q0lEBSVi70oie2xFFXr ncrw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b35-v6si18630212plh.36.2018.07.11.01.44.12; Wed, 11 Jul 2018 01:44:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732409AbeGKIqf (ORCPT + 99 others); Wed, 11 Jul 2018 04:46:35 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:37328 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726280AbeGKIqe (ORCPT ); Wed, 11 Jul 2018 04:46:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7FEF3401CC41; Wed, 11 Jul 2018 08:43:22 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-149.rdu2.redhat.com [10.10.120.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id 97A9E10190; Wed, 11 Jul 2018 08:43:21 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <153126248868.14533.9751473662727327569.stgit@warthog.procyon.org.uk> <153126264966.14533.3388004240803696769.stgit@warthog.procyon.org.uk> <686E805C-81F3-43D0-A096-50C644C57EE3@amacapital.net> <20180711011520.GL30522@ZenIV.linux.org.uk> To: Andy Lutomirski Cc: dhowells@redhat.com, Al Viro , Linus Torvalds , Linux API , linux-fsdevel , Linux Kernel Mailing List , Jann Horn Subject: Re: [PATCH 24/32] vfs: syscall: Add fsopen() to prepare for superblock creation [ver #9] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24375.1531298601.1@warthog.procyon.org.uk> Date: Wed, 11 Jul 2018 09:43:21 +0100 Message-ID: <24376.1531298601@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Jul 2018 08:43:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Wed, 11 Jul 2018 08:43:22 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dhowells@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Lutomirski wrote: > > Umm... How about "use credentials of opener for everything"? > > If you want to audit every single filesystem for any code that uses > credentials for anything and add all the right kernel APIs and make > sure the filesystem uses them and somehow keep screwups from getting > added down the line, then okay I guess. As far as I know, we don't > even *have* an API for "open this device node using this struct cred > *". You can use override_creds() too. David