Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp258386imm; Wed, 11 Jul 2018 01:46:31 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe9hBdU0a+1xzZeutr8oXXPwMh4JbZpcCqc2+T37Uvxi6C1HdqmdE4qxVQFie37Lhgjov+P X-Received: by 2002:a63:dc17:: with SMTP id s23-v6mr4035780pgg.40.1531298791406; Wed, 11 Jul 2018 01:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531298791; cv=none; d=google.com; s=arc-20160816; b=I9eiLmOXZQ8xuga0JZO62D26urHSAKbj3ALGTbCzyHYll1gtLIOdOAklFD/bnRF9SN MVVaeuGOb0mTEkOdzGUXn3xCNq4x7EYC47D0RwaVxAy7BgYVVNuQbJ7W4WdsTb5/xMhN 55jV+xdLr5cwZthr8SthxrbWOSxG4EvkC7gzrLNysfkA4YF2VL+rvUSzrIBqvUfKL4zs qFvy0Ce3UDPepE2O+k+cb/XF0teYcHK/d7uZMe4srVlSeFdHRcZtMwuwlC2BhNGkEVSc UfV6UMR0a8WSGyBATAjemCelcFnG5u5A8dzKfnvclf223ZPgIadJesEzg11VWP7rwuyl Tasw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=lIe/DLWc/iKEgC2Wmet738q1s4rkKcXLtns8ACW0XY0=; b=Vy1IjJ/KLxztVHUJjTtJEN8G93PwxnKQW1hKIMFRvhKlaS4Yuwi0ZsVxyKGIBuycxD NWrhqocYeevgLz9Jb8Ena89Ay0vKhIf7ZiugGEG0fHKdDRMGMQz6BwIicIc0CgfUjgAh J2R4C9ECneRVpWBl86oBCZ8SQkF8lPGYo4WAX1UdNE9OQwTWsgqV1s6J67njm5woeS1L OhWGBj5Emi6tu3TWQaF4+/0w23aOtGAI/0MfzcHI/W/QT479FJqQ62VpYRjR4WzMAr+5 rG118ug0Hsb8ZtmBsU+u/5MgwmbO8q+o7yVcubCeWbM1EpqNC+ymQolVB77jzZqZdr8m oHHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=SsL26y7+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j129-v6si18493296pgc.186.2018.07.11.01.46.16; Wed, 11 Jul 2018 01:46:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=SsL26y7+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732394AbeGKIsm (ORCPT + 99 others); Wed, 11 Jul 2018 04:48:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:59950 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726321AbeGKIsm (ORCPT ); Wed, 11 Jul 2018 04:48:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=lIe/DLWc/iKEgC2Wmet738q1s4rkKcXLtns8ACW0XY0=; b=SsL26y7+9lThMOkozGZ+4XLOd T8Li2QTbhe18etiwfUqrfDK7WavNXeKjtywm5AIMaVlRKNRPSOIWPuN+wUxk6YQJeeorTWsjzyQ2t LTtv0Cwl63VanN2/tr3HwnW9DIsJ8SNhL1Cbmk2h7+ImhdiDmyYP+fl+Cvwc2P0j7rK7RD3ZE+E0/ Na9AIhkxx+oswqZwscpuSE58KaGhTm505N/fJoJpZgDDeXR+7SXXMMY5buq1B6GVHOKdAoicINsvW pCYjVQMhteRLu1S8MAlsUuLa6vaDZ1lBYorjMVsrABhWNtiA3ykG/Ff5n5jrDTFFj8Gg8MvIEjbKn kWnvGjxPg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdAkS-0007xB-IG; Wed, 11 Jul 2018 08:45:20 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7BA5A20291063; Wed, 11 Jul 2018 10:45:18 +0200 (CEST) Date: Wed, 11 Jul 2018 10:45:18 +0200 From: Peter Zijlstra To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [RFC PATCH v2 10/27] x86/mm: Introduce _PAGE_DIRTY_SW Message-ID: <20180711084518.GQ2476@hirez.programming.kicks-ass.net> References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-11-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180710222639.8241-11-yu-cheng.yu@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 10, 2018 at 03:26:22PM -0700, Yu-cheng Yu wrote: > + pte = pte_clear_flags(pte, _PAGE_DIRTY_SW); > return pte_set_flags(pte, _PAGE_DIRTY_HW | _PAGE_SOFT_DIRTY); Having both _PAGE_DIRTY_SW and _PAGE_SOFT_DIRTY is really confusing. I'm not sure I have an anwser for this, but urggh.