Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp384478imm;
        Wed, 11 Jul 2018 04:19:34 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpfa72NCsUvBJFB5c85RuVIdF5q6mfb5dHmPmkH75+ka4MLYH4KtNXqK+UYmoS11N1Ddt3lT
X-Received: by 2002:a63:1a49:: with SMTP id a9-v6mr26846410pgm.423.1531307974656;
        Wed, 11 Jul 2018 04:19:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1531307974; cv=none;
        d=google.com; s=arc-20160816;
        b=nEQJy43eUi1+WrWww6Ob7rYe+IHOm6Fmfn1Y5V3l6reXAnlw8bHguksy1cr/7Dp47K
         NZTONfAfo8Fj5WQdwETAV4vYfBPwYBOEBYm327RssqHIp0pvakO3NUsl4qMI8hQtbGhW
         rX3IL8KKu59Swa+6u4+0YLn+S/ziAnxLQEUitkwXFodUlVMzTuEkvNdlbwcSxMFk6qVs
         FTQUuYQ98i6nMvsKAq+Y165Db8eSMIH0B5vehyCom5VNbyHxIA1an92tdAd/tb0n8Hjl
         9mp/sl4DQ5UN33VaaCHvmOKzLj7QtagwZrK4QP3VEOUvQtXbzRDoTjOu8UxvsV3UBYsA
         JOTA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:arc-authentication-results;
        bh=ML5lZWzCnvGoSJ2ma1zh9wFa44t2FJP79WUvjfSU/eg=;
        b=DXWDTTIZRXfXxM9x7PTnj6ddXBEBi2WMAMoqqJSJCnmvFKVuqi3ScZMJEghNLOCw7C
         Npz2IHMtehPUz32VrnKPfY6e6HH5uf7btra1H3FMTdoLm0G4wrKih7KjMeWjgMRSKnB4
         cwp8LdgS9LpreWRcvXofpuoMLt8z13gz6Z5w5Vx3VKtlW6MUgG9aTbceepFhKV+DQ19g
         PPJiMENvURBS/+GObVJMw/FSbguyjrhFSXFc4OrNONI9pk6jqXkkrNp0DexWYMoDJIIm
         zCxx0Lslf15CXsX8CsQk682otX2UboAS0Iv+OzMs8wpc/cic7SJZfkey99FgKWge4ey5
         XOQw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id u76-v6si21712734pfj.58.2018.07.11.04.19.18;
        Wed, 11 Jul 2018 04:19:34 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1732661AbeGKLVt (ORCPT <rfc822;jimmypw@gmail.com> + 99 others);
        Wed, 11 Jul 2018 07:21:49 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:16855 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732535AbeGKLVs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jul 2018 07:21:48 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b45e7630000>; Wed, 11 Jul 2018 04:17:55 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 11 Jul 2018 04:17:54 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 11 Jul 2018 04:17:54 -0700
Received: from tbergstrom-lnx.Nvidia.com (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 11 Jul
 2018 11:17:57 +0000
Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1002)
        id 2D79BF8009D; Wed, 11 Jul 2018 14:17:54 +0300 (EEST)
Date:   Wed, 11 Jul 2018 14:17:54 +0300
From:   Peter De Schrijver <pdeschrijver@nvidia.com>
To:     Jon Hunter <jonathanh@nvidia.com>
CC:     Aapo Vienamo <avienamo@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation
Message-ID: <20180711111754.GC1636@tbergstrom-lnx.Nvidia.com>
References: <1531154338-3998-1-git-send-email-avienamo@nvidia.com>
 <1531154338-3998-3-git-send-email-avienamo@nvidia.com>
 <5805047f-4099-db34-0759-42e4a9e11629@nvidia.com>
 <20180711080022.GB1636@tbergstrom-lnx.Nvidia.com>
 <ef90eb24-e993-9cc1-ac09-5afedeceba75@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ef90eb24-e993-9cc1-ac09-5afedeceba75@nvidia.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL108.nvidia.com (172.18.146.13) To
 HQMAIL101.nvidia.com (172.20.187.10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 11, 2018 at 09:42:20AM +0100, Jon Hunter wrote:
> 
> On 11/07/18 09:00, Peter De Schrijver wrote:
> > On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote:
> >>
> >> On 09/07/18 17:38, Aapo Vienamo wrote:
> >>> From: Peter De Schrijver <pdeschrijver@nvidia.com>
> >>>
> >>> Move this to a separate file so it can be used to calculate the sdmmc
> >>> clock dividers.
> >>
> >> Sorry for not commenting sooner, but what is the motivation for moving
> >> this to its own file? I don't see why we need to do this in order to use
> >> elsewhere. Furthermore, the original file is quite aptly named 'clk-divider.c'
> >> and now we have a div71.c which seems quite specific.
> > 
> > How else would you do it?
> 
> Keep it in the same file?
> 

That seems odd. clk-divider.c is meant to implement a clock type, not
utility functions we happen to need in several types.

Peter.