Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp397259imm; Wed, 11 Jul 2018 04:33:51 -0700 (PDT) X-Google-Smtp-Source: AAOMgpdhTQ32XzJbi9bw4tQfkiWWO8Wlyp3M+9Qk7uOf5/uppHgFXSaZSkrBolYnRFu8ra8e4XBF X-Received: by 2002:a63:4811:: with SMTP id v17-v6mr21317104pga.379.1531308831569; Wed, 11 Jul 2018 04:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531308831; cv=none; d=google.com; s=arc-20160816; b=gAldztjmAcc4ww/Xsy/dWKR8+RPpFjk+dJO9APgXLrMaocvLCHwXgs4Ypnwz6nw+8D kYoDOILtk3y9ptkRLWHuXxv06Z2PEG0Mi7pteadRlnFxTbxpO4QsF3TabvfT3YwJD3xr PUdpUKoc7rU4H41yNiQWNzMgFN7ComL1CmUxY/LzeoNGgl9frBE3g1aEPQmDyBLeMTyN iRU+VwNw/guMlIXRVY2R7pBCZblAFCfqRu18rHMB2aSV0dtEx8LXsa1gjD5sdfEmv84S 1TQ+0oWhlSqlB6G0a2a2wEJfLbr+Iq2QflOuZYjeJNaYWpEYb4wLlyVqfEsVldNC7M4I vdPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=OrnmTOXfzkEJCgjbaAcFYEuMOEXQw/hGjcfDkWOHbmA=; b=K/Tl6PGdva6DZCStcHqj/urC0CLMpu67yQyXSeJCy93jFbb49Lshb77A/IHeCX21V4 +zLIo58gpBeXduKGvndCd93y/+0j/v8SOnnT8JaFid9f5/jOHWCaoeBWGoi9qt+jUCqS 9mITa+M/sFSDvXJuuB9dcGzi3OifbI5pZ4+zkwtNfvC2SNQH9RbJWKls6jo7+RzwH68P OqvXdNPGmZ0gHi+ImsYYVibxB5KFWLVNKYHw9ay7zolQMiye5yCkFVMmLQ805fR4RGwV 0khx+i7SJwUAHcH+gWsAFq43+bgNpMtb/MoMN6QbfkApqDvMz/fiB9eaEzX0uOmOshC1 fCDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=H71NWJ3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1-v6si5204680pgg.643.2018.07.11.04.33.36; Wed, 11 Jul 2018 04:33:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@8bytes.org header.s=mail-1 header.b=H71NWJ3R; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733174AbeGKLg0 (ORCPT + 99 others); Wed, 11 Jul 2018 07:36:26 -0400 Received: from 8bytes.org ([81.169.241.247]:37802 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732808AbeGKLeG (ORCPT ); Wed, 11 Jul 2018 07:34:06 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id D6042A21; Wed, 11 Jul 2018 13:30:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1531308603; bh=iEPn9yhr8K3WkTxVGik81NaWC4cuH7/tnosk3392xlQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H71NWJ3RgeMUV6UFc1T3TwJPaj/ltMHQ87VHoBqOUY8y8R6uMG3ZsJCJsT0+4ihMW O0GBl0bwd9/qPL4tsl3hepz1/sTZ9spudVtM5YYhOwZldKLGz+rfaxG2d2S47lV11w 6qU277FpZjdTd8rY+zxofhrJLoH6la5lZ0+4ReH0/OAl8GhUbI0a1NIdB5YoTK1zc+ Ucek/sA3LaWftUz1UuAsIbpdGrZBJccJ0DbluJV/5TdPSceLdX/5SOpR25kMpakzUh VxigK92C7XEQoZP+kde7VmOW1zd15XssG8STqtCq3cEimxiA86pqUSyNduhbnLFZ+h RIMAksXwEsHHQ== From: Joerg Roedel To: Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Linus Torvalds , Andy Lutomirski , Dave Hansen , Josh Poimboeuf , Juergen Gross , Peter Zijlstra , Borislav Petkov , Jiri Kosina , Boris Ostrovsky , Brian Gerst , David Laight , Denys Vlasenko , Eduardo Valentin , Greg KH , Will Deacon , aliguori@amazon.com, daniel.gruss@iaik.tugraz.at, hughd@google.com, keescook@google.com, Andrea Arcangeli , Waiman Long , Pavel Machek , "David H . Gutteridge" , jroedel@suse.de, joro@8bytes.org Subject: [PATCH 18/39] x86/pgtable: Move pgdp kernel/user conversion functions to pgtable.h Date: Wed, 11 Jul 2018 13:29:25 +0200 Message-Id: <1531308586-29340-19-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531308586-29340-1-git-send-email-joro@8bytes.org> References: <1531308586-29340-1-git-send-email-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joerg Roedel Make them available on 32 bit and clone_pgd_range() happy. Signed-off-by: Joerg Roedel --- arch/x86/include/asm/pgtable.h | 49 +++++++++++++++++++++++++++++++++++++++ arch/x86/include/asm/pgtable_64.h | 49 --------------------------------------- 2 files changed, 49 insertions(+), 49 deletions(-) diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h index 5715647..eb47432 100644 --- a/arch/x86/include/asm/pgtable.h +++ b/arch/x86/include/asm/pgtable.h @@ -1155,6 +1155,55 @@ static inline pmd_t pmdp_establish(struct vm_area_struct *vma, } #endif +#ifdef CONFIG_PAGE_TABLE_ISOLATION +/* + * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages + * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and + * the user one is in the last 4k. To switch between them, you + * just need to flip the 12th bit in their addresses. + */ +#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT + +/* + * This generates better code than the inline assembly in + * __set_bit(). + */ +static inline void *ptr_set_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr |= BIT(bit); + return (void *)__ptr; +} +static inline void *ptr_clear_bit(void *ptr, int bit) +{ + unsigned long __ptr = (unsigned long)ptr; + + __ptr &= ~BIT(bit); + return (void *)__ptr; +} + +static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) +{ + return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) +{ + return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) +{ + return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} + +static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) +{ + return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); +} +#endif /* CONFIG_PAGE_TABLE_ISOLATION */ + /* * clone_pgd_range(pgd_t *dst, pgd_t *src, int count); * diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h index 9406c4f..4adba19 100644 --- a/arch/x86/include/asm/pgtable_64.h +++ b/arch/x86/include/asm/pgtable_64.h @@ -132,55 +132,6 @@ static inline pud_t native_pudp_get_and_clear(pud_t *xp) #endif } -#ifdef CONFIG_PAGE_TABLE_ISOLATION -/* - * All top-level PAGE_TABLE_ISOLATION page tables are order-1 pages - * (8k-aligned and 8k in size). The kernel one is at the beginning 4k and - * the user one is in the last 4k. To switch between them, you - * just need to flip the 12th bit in their addresses. - */ -#define PTI_PGTABLE_SWITCH_BIT PAGE_SHIFT - -/* - * This generates better code than the inline assembly in - * __set_bit(). - */ -static inline void *ptr_set_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr |= BIT(bit); - return (void *)__ptr; -} -static inline void *ptr_clear_bit(void *ptr, int bit) -{ - unsigned long __ptr = (unsigned long)ptr; - - __ptr &= ~BIT(bit); - return (void *)__ptr; -} - -static inline pgd_t *kernel_to_user_pgdp(pgd_t *pgdp) -{ - return ptr_set_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline pgd_t *user_to_kernel_pgdp(pgd_t *pgdp) -{ - return ptr_clear_bit(pgdp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *kernel_to_user_p4dp(p4d_t *p4dp) -{ - return ptr_set_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} - -static inline p4d_t *user_to_kernel_p4dp(p4d_t *p4dp) -{ - return ptr_clear_bit(p4dp, PTI_PGTABLE_SWITCH_BIT); -} -#endif /* CONFIG_PAGE_TABLE_ISOLATION */ - /* * Page table pages are page-aligned. The lower half of the top * level is used for userspace and the top half for the kernel. -- 2.7.4