Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp655031imm; Wed, 11 Jul 2018 08:45:19 -0700 (PDT) X-Google-Smtp-Source: AAOMgpemCuoeR71nR8tEZIrmrHZsQ2AVj+G6WzsbD/ePPYFcp3pAYccaVzxarZWW06Il8JI/keNw X-Received: by 2002:a62:5582:: with SMTP id j124-v6mr30748020pfb.20.1531323919605; Wed, 11 Jul 2018 08:45:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531323919; cv=none; d=google.com; s=arc-20160816; b=Mf4Fkla3Iz3XzxvvWUSgIkNWFPOzsyjWZqqHxa+mvu/kndYcXzHwFi24QIKhhFl+l5 gfe2cageSBjGXOwU6D+K8jundZJA3fBaNi/TgjXcv6iUE7OO/6kY1qd3ucphylXP7Qpo fUhOzo06MgH5IQ4+O1LsBFhg7pjOumDiZVsvBtBuMcvXhINX8J39J+RQERIaFHQpTyB+ 3UBeIEZOiIl1NydoHiF69FFGPXHfQqwIEwQ6Q8AiIn5mfN1/gm5m+Fkk76R01RIRCseJ +UHIVL1qkmC9y6gm01N1kis5kuN6Bddhk781RKywHAa4rYWupfMcwqLWIU4T9lQ//eCD mpgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=VG1NbK2ftky8pbu8og2XqijVszcv9E31gevxcAaEqaQ=; b=EH6cXPFJei69dkGzUqZSiHwBLTp0g35InexeRPcXLSE185QfQIHsq4cPXruF+YI73Y /f7UV9VRUUl2SkqGNGjJ/689lWG3KL8mKud+jdAEBipywBYWN60veHxQVNkkau2JkN0w FeDXUHqLEx74AjP4utujb6M/ViSoO0SWdexeLtM9UGzmHYKj6O/f+2g60LxvEx+L0c3J S4ks4A9CuGvSI5gSPT+OYRD6MPw57lXpVgJ5RdAxcTCpU07bBYS33s2mjdYLvErVVCRj rPX7LyPDTZ5JGV7jhxl2HgF6jKiAleqiZMdO4IWqUKGP9fq0qtddNl653/xfpZxqc6Qq U0yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1-v6si18733696plt.183.2018.07.11.08.45.04; Wed, 11 Jul 2018 08:45:19 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387638AbeGKNDz (ORCPT + 99 others); Wed, 11 Jul 2018 09:03:55 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:35266 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732876AbeGKNDz (ORCPT ); Wed, 11 Jul 2018 09:03:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C426C7A9; Wed, 11 Jul 2018 05:59:41 -0700 (PDT) Received: from [10.1.206.73] (en101.cambridge.arm.com [10.1.206.73]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6282C3F5AD; Wed, 11 Jul 2018 05:59:40 -0700 (PDT) Subject: Re: [PATCH v5 1/7] KVM: arm/arm64: Share common code in user_mem_abort() To: Punit Agrawal , kvmarm@lists.cs.columbia.edu Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, christoffer.dall@arm.com, linux-kernel@vger.kernel.org, will.deacon@arm.com References: <20180709143835.28971-1-punit.agrawal@arm.com> <20180709144124.29164-1-punit.agrawal@arm.com> From: Suzuki K Poulose Message-ID: <9470f63a-6e8c-aeb6-7648-ad5fc7f24904@arm.com> Date: Wed, 11 Jul 2018 13:59:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180709144124.29164-1-punit.agrawal@arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/07/18 15:41, Punit Agrawal wrote: > The code for operations such as marking the pfn as dirty, and > dcache/icache maintenance during stage 2 fault handling is duplicated > between normal pages and PMD hugepages. > > Instead of creating another copy of the operations when we introduce > PUD hugepages, let's share them across the different pagesizes. > > Signed-off-by: Punit Agrawal > Cc: Christoffer Dall > Cc: Marc Zyngier > --- > virt/kvm/arm/mmu.c | 67 ++++++++++++++++++++++++++-------------------- > 1 file changed, 38 insertions(+), 29 deletions(-) > Reviewed-by: Suzuki K Poulose