Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp723602imm; Wed, 11 Jul 2018 09:53:17 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcUq3+1iiSGqKqEGD6p/6IhcxhLm3zkRayuYsrL36Z6VKLFxUWUyaiFjykt4HKoPgirWn7r X-Received: by 2002:a62:2983:: with SMTP id p125-v6mr16817508pfp.128.1531327997665; Wed, 11 Jul 2018 09:53:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531327997; cv=none; d=google.com; s=arc-20160816; b=NjHMWQ2dkO7nuPEOTrsSiDbPAwKNh3uDsQK4zeL4kjtpA30tgJMrgg5mO/PNWVbld1 NTF0AapzQ9ABPihYgz4BwNDr107ITVZwliY8I5xUXcn2AAkoggEYO47WOYaJAgKgzYnz 20GeoDdBGS9OfMU41zfEqdcKSTuKSbbvYLJDvxU4ryOJxP2vn9H5x7lTw3ZXCfBtgODT jwLmaay0MJxwhBldA5nsiwcwxRHbz/YCUYLBPjBp3RbcsWMPrdMVBKWDb35f3lJog9ZA iWyDOY5RdhX24Yhosw5W1rwzF6VEbFvIkHIdpjq6sA51E1d+dNoz2Yc5vr3YnBOxnS3n 9Nfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:arc-authentication-results; bh=7SzyHU0YoZY4vNX0zadXzqiX5lce00pK+Dh+sOWS+0s=; b=ReRem45zb2DXM3dxiCiYG79LI7vvc0UkniCvGp6oNo0EegpRvAPxF/GDR5y3dK5vSk Vo36xlY/Iel1EAZIorJFmqwIsbG0CDp184Ql+ytBcJFsOnaWR2wYtElqtRjaBh7c/s4s EZyQbF4Jt5+XghqnjUSJELvZrkw5XfeiReNhrJ+1IzPOCsjTHe5ahGMbglFNnJ9V5a1H 8tGlJTs/zpCPpPbWZZaaJtfnsabMTn7ENX7m4vxrk3nGGJWrOI6xL5KtYDNYfPviUYGd pMPdg8NQ3jJlSiKxNX0FCTvXY6/2KnFaZz3mtTQfyjijdM6F9HPUn/DM3qPQSpWOEAFF N0+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i38-v6si18937174pgm.394.2018.07.11.09.53.01; Wed, 11 Jul 2018 09:53:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388420AbeGKOGZ (ORCPT + 99 others); Wed, 11 Jul 2018 10:06:25 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:5373 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387708AbeGKOGY (ORCPT ); Wed, 11 Jul 2018 10:06:24 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA) id ; Wed, 11 Jul 2018 07:01:51 -0700 Received: from HQMAIL101.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 11 Jul 2018 07:01:54 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 11 Jul 2018 07:01:54 -0700 Received: from dhcp-10-21-25-168.Nvidia.com (10.21.25.201) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 11 Jul 2018 14:01:51 +0000 From: Aapo Vienamo To: Rob Herring , Mark Rutland , Thierry Reding , Jonathan Hunter , Mikko Perttunen CC: Aapo Vienamo , , , Subject: [PATCH v2 2/7] soc/tegra: pmc: Factor out DPD register bit calculation Date: Wed, 11 Jul 2018 17:01:28 +0300 Message-ID: <1531317693-3520-3-git-send-email-avienamo@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1531317693-3520-1-git-send-email-avienamo@nvidia.com> References: <1531317693-3520-1-git-send-email-avienamo@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.21.25.201] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To HQMAIL101.nvidia.com (172.20.187.10) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Factor out the the code to calculate the correct DPD register and bit number for a given pad. This logic will be needed to query the status register. Signed-off-by: Aapo Vienamo Acked-by: Jon Hunter --- drivers/soc/tegra/pmc.c | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c index f926332..393ca72 100644 --- a/drivers/soc/tegra/pmc.c +++ b/drivers/soc/tegra/pmc.c @@ -922,11 +922,12 @@ tegra_io_pad_find(struct tegra_pmc *pmc, enum tegra_io_pad id) return NULL; } -static int tegra_io_pad_prepare(enum tegra_io_pad id, unsigned long *request, - unsigned long *status, u32 *mask) +static int tegra_io_pad_get_dpd_register_bit(enum tegra_io_pad id, + unsigned long *request, + unsigned long *status, + u32 *mask) { const struct tegra_io_pad_soc *pad; - unsigned long rate, value; pad = tegra_io_pad_find(pmc, id); if (!pad) { @@ -947,6 +948,19 @@ static int tegra_io_pad_prepare(enum tegra_io_pad id, unsigned long *request, *request = pmc->soc->regs->dpd2_req; } + return 0; +} + +static int tegra_io_pad_prepare(enum tegra_io_pad id, unsigned long *request, + unsigned long *status, u32 *mask) +{ + unsigned long rate, value; + int err; + + err = tegra_io_pad_get_dpd_register_bit(id, request, status, mask); + if (err) + return err; + if (pmc->clk) { rate = clk_get_rate(pmc->clk); if (!rate) { -- 2.7.4