Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1531315019-3553-1-git-send-email-laoar.shao@gmail.com> <1531315019-3553-2-git-send-email-laoar.shao@gmail.com>
In-Reply-To: <1531315019-3553-2-git-send-email-laoar.shao@gmail.com>
From:   Eric Dumazet <edumazet@google.com>
Date:   Wed, 11 Jul 2018 07:56:59 -0700
Message-ID: <CANn89iLkt+WC36QRKeB7N+DsqCmERnRj5a21+uBjATT7RzyLAA@mail.gmail.com>
Subject: Re: [PATCH net-next 2/2] tcp: refactor tcp_queue_rcv
To:     Yafang Shao <laoar.shao@gmail.com>
Cc:     David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, shaoyafang@didichuxing.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yafang
On Wed, Jul 11, 2018 at 6:17 AM Yafang Shao <laoar.shao@gmail.com> wrote:
>
> There're are some code similar to tcp_queue_rcv() in tcp_ofo_queue(),
> so refactor tcp_queue_rcv() to make it be used in tcp_ofo_queue().
>
> After this change, skb->sk is set when skb is moved from ofo queue into
> receive queue instead of when queued into ofo queue.

Why would you do that ???

I urge you to test this on hosts connected to the wild Internet :/