Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <153131984019.24777.15284245961241666054.stgit@localhost.localdomain>
References: <153131984019.24777.15284245961241666054.stgit@localhost.localdomain>
To:     Kirill Tkhai <ktkhai@virtuozzo.com>
Cc:     dhowells@redhat.com, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] fs: Fix double prealloc_shrinker() in sget_fc()
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <24666.1531321044.1@warthog.procyon.org.uk>
Date:   Wed, 11 Jul 2018 15:57:24 +0100
Message-ID: <24667.1531321044@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Kirill Tkhai <ktkhai@virtuozzo.com> wrote:

> diff --git a/fs/super.c b/fs/super.c
> index 13647d4fd262..47a819f1a300 100644
> --- a/fs/super.c
> +++ b/fs/super.c
> @@ -551,7 +551,7 @@ struct super_block *sget_fc(struct fs_context *fc,
>  	hlist_add_head(&s->s_instances, &s->s_type->fs_supers);
>  	spin_unlock(&sb_lock);
>  	get_filesystem(s->s_type);
> -	register_shrinker(&s->s_shrink);
> +	register_shrinker_prepared(&s->shrinker);
>  	return s;
>  }
>  EXPORT_SYMBOL(sget_fc);
> 

I already folded in a fix from Eric for this, but Al hasn't pulled the updated
tree yet.

David