Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jernej =?utf-8?B?xaBrcmFiZWM=?= <jernej.skrabec@gmail.com>
To:     linux-sunxi@googlegroups.com, maxime.ripard@bootlin.com
Cc:     Icenowy Zheng <icenowy@aosc.io>, Chen-Yu Tsai <wens@csie.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [linux-sunxi] Re: [PATCH 1/2] ARM: sun8i: h3: enable HDMI output on Banana Pi M2 Zero
Date:   Wed, 11 Jul 2018 17:14:19 +0200
Message-ID: <3039364.lZKhBVCAIj@jernej-laptop>
In-Reply-To: <20180711150532.6gzm7krouriddreh@flea>
References: <20180711132233.42301-1-icenowy@aosc.io> <20180711132233.42301-2-icenowy@aosc.io> <20180711150532.6gzm7krouriddreh@flea>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Dne sreda, 11. julij 2018 ob 17:05:32 CEST je Maxime Ripard napisal(a):
> Hi,
> 
> On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
> > Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
> > controller of Allwinner H3 SoC.
> > 
> > Enable the HDMI output in Banana Pi M2 Zero device tree.
> > 
> > Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> > ---
> > 
> >  .../dts/sun8i-h2-plus-bananapi-m2-zero.dts    | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts index
> > 7d01f9322658..eb61dcf32797 100644
> > --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
> > @@ -26,6 +26,17 @@
> > 
> >  		stdout-path = "serial0:115200n8";
> >  	
> >  	};
> > 
> > +	hdmi-connector {
> > +		compatible = "hdmi-connector";
> > +		type = "c";
> 
> This is not one of the connector type declared in DRM, how is it
> exposed to the userspace?

DT binding allows it:

HDMI Connector
==============

Required properties:
- compatible: "hdmi-connector"
- type: the HDMI connector type: "a", "b", "c", "d" or "e"

but DW HDMI bridge driver hardcodes it to type A. Actually, kernel has defines 
only for type A and B.

Actually, many HDMI drivers have type A hardcoded...

Best regards,
Jernej