Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp849913imm; Wed, 11 Jul 2018 12:02:49 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcsOjuTthwAflLPYCd5efjk5di0in8/8yEaIdHrVeVChWBerxq28zUENvK8XxDdsMEUkj2s X-Received: by 2002:a62:858c:: with SMTP id m12-v6mr31379152pfk.173.1531335769173; Wed, 11 Jul 2018 12:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531335769; cv=none; d=google.com; s=arc-20160816; b=1Lbg4P4do2xW3u4GRSVdIqwy6QWKjKZutOZqOilhBgwVdUeWZLBEZdbppzYxw23TrI hYAzOJRsu7as+ZeHs35KMaaRYFJxebiT+yfmb3TZAZY6YlCJPe+h0t7xWlBBjpGbjds1 pE9hTkTxWVVtlVvQs1lH9ZCF/3ktvsYSYtxo6vtT7saXZeKwhI/XW7oZKHRWHRqsvhqf ght500F7/Bf0CVb/Ws7UgtsfAG7ORnuZP51+ZCyt7G3mRCi4oXwWK5tq2wGesnSQcuTd QV633C94JTGrmrDYYdsE4+igEVCpT1ZN/dn1ZS+2uGjBptwuEc+o0M2HVDyh/HTUolqv NlJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from :arc-authentication-results; bh=sDewBMB80Umso6XUIwQ5PSiWcRzgVHb6Ci3MVR0Hscs=; b=JvI1OSCZSOKzivjg2zMAX2DSH6vVwmsuiWwfZFU/PVVle2uag2gaEODjWkZri6lZll 9fThmM8go6bYzq/h9nGARjyrfE4UB7pnhkizn6indApPafSpvDNkYSEmo6BCliM0XGku HPJokTqfW5/sERvitAw2GbQfJcIm8v8waDlfJyLuqICS/aiju2pNFgTZmXqYDm4/zyVS clb0f/h7BNQUbydtHkTlR6zHg+c7JLw90EyWgs2wWiKsF+XSn36ajkxl+hkIYXPxWz2m BnP+PiOO+HkIa2aTxym37nBXvROeyrbJXp9mXVwEmXwh8Zf7UjIlpYnWCInh08n33RAR lzoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v21-v6si19364336pgn.371.2018.07.11.12.02.22; Wed, 11 Jul 2018 12:02:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389608AbeGKQPz (ORCPT + 99 others); Wed, 11 Jul 2018 12:15:55 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39542 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387728AbeGKQPz (ORCPT ); Wed, 11 Jul 2018 12:15:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8483B7A9; Wed, 11 Jul 2018 09:10:53 -0700 (PDT) Received: from localhost (e105922-lin.cambridge.arm.com [10.1.206.33]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2879B3F589; Wed, 11 Jul 2018 09:10:53 -0700 (PDT) From: Punit Agrawal To: Suzuki K Poulose Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, linux-kernel@vger.kernel.org, will.deacon@arm.com, Russell King , Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 2/7] KVM: arm/arm64: Introduce helpers to manupulate page table entries References: <20180709143835.28971-1-punit.agrawal@arm.com> <20180709144124.29164-1-punit.agrawal@arm.com> <20180709144124.29164-2-punit.agrawal@arm.com> <691fcde0-b0a2-d258-ac99-49c6c4794247@arm.com> Date: Wed, 11 Jul 2018 17:10:51 +0100 In-Reply-To: <691fcde0-b0a2-d258-ac99-49c6c4794247@arm.com> (Suzuki K. Poulose's message of "Wed, 11 Jul 2018 14:00:48 +0100") Message-ID: <87va9loir8.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Suzuki K Poulose writes: > On 09/07/18 15:41, Punit Agrawal wrote: >> Introduce helpers to abstract architectural handling of the conversion >> of pfn to page table entries and marking a PMD page table entry as a >> block entry. >> >> The helpers are introduced in preparation for supporting PUD hugepages >> at stage 2 - which are supported on arm64 but do not exist on arm. >> >> Signed-off-by: Punit Agrawal >> Acked-by: Christoffer Dall >> Cc: Marc Zyngier >> Cc: Russell King >> Cc: Catalin Marinas >> Cc: Will Deacon >> --- > > Reviewed-by: Suzuki K Poulose Other than the query on Patch 7 I've incorporated all your suggestions locally. Thanks a lot for reviewing the patches. Punit ps: Just noticed the typo (manupulate) in the subject. I've fixed it up locally.