Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp937376imm;
        Wed, 11 Jul 2018 13:50:11 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpdRhB4AqRK29NAikeuQJtz0/WVDH0abOBxIwYGmTEmDFmVQnHhxQOF5Byw+UwxcVzsHAr1D
X-Received: by 2002:a63:6004:: with SMTP id u4-v6mr138291pgb.441.1531342211000;
        Wed, 11 Jul 2018 13:50:11 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1531342210; cv=none;
        d=google.com; s=arc-20160816;
        b=cGCDC58ZJqzh5VhgIqbHiKbaJTaJ/lwRsf8zkfykjeQoOHsxJCmbRvsJuQfqkpzqDN
         qAzRFcRscG7JzVGk6n2d9EGk6JZWf6j1/33hx+3S7gG+5jt3DDDUtbFh+0LbdLDElcna
         uPbwzzWAS46u4wO3OrfsSDPplsOi2Saa93gKUCKh8HJTLRYGl04sMC7G7OSfqsHmAg2+
         DOf1I791h3r0Tm6FpqeU7ew6mmYUHj5kuSYuC/G1hQBQVcJvgyCKXZv3VP0xRdssYdso
         l7HMOsNQxHPgoqu1jvko3i6FjD8Feco6SsRL1uOYo6MMYKLOapa91pONPgj1TubMxjl6
         tz1w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject:arc-authentication-results;
        bh=+LdMoRTyHV0eLXlhLuM6hDZ87LFgPuCStPnhyuOPV3k=;
        b=Z0Pk8N1PfBAlQ3wZ60XcSaRC8RECpHhbIC0h3BEnqAu5vEjwCLJNonwZFqAtyM45OO
         QuJ/NZ9peui7h7kOaQDTwnsyd8vSQ7B/vJuqBH+GnDdL5PK1B1jegRrRfi9kZemHf+aP
         e9r+NE172gQWf9IMNCkAFaagE1GMhL4NrkSDmRzd/LxV7uGVhkb7iXIwR5mMqxxxsz0X
         jAPiitrp82nDg+M0a5xEDSdK+n5oTMOU6YBVoIQjFrGJRVp8iyycDm73tvy1oU/v/JKF
         Tpnuoc2tL0ehTatqBy5YKRZbGMHrVFZU8x83+gXBTEmOjMlmk4Kt612gRPdR03QRUFtv
         X+TQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id b18-v6si19381694pge.666.2018.07.11.13.49.55;
        Wed, 11 Jul 2018 13:50:10 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2388947AbeGKPTG (ORCPT <rfc822;jimmypw@gmail.com> + 99 others);
        Wed, 11 Jul 2018 11:19:06 -0400
Received: from hqemgate14.nvidia.com ([216.228.121.143]:9064 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2388936AbeGKPTF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jul 2018 11:19:05 -0400
Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1, AES128-SHA)
        id <B5b461ec70002>; Wed, 11 Jul 2018 08:14:15 -0700
Received: from HQMAIL101.nvidia.com ([172.20.161.6])
  by hqpgpgate102.nvidia.com (PGP Universal service);
  Wed, 11 Jul 2018 08:14:14 -0700
X-PGP-Universal: processed;
        by hqpgpgate102.nvidia.com on Wed, 11 Jul 2018 08:14:14 -0700
Received: from [10.21.132.122] (10.124.1.5) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 11 Jul
 2018 15:14:15 +0000
Subject: Re: [PATCH v4 2/4] clk: tegra: refactor 7.1 div calculation
To:     Peter De Schrijver <pdeschrijver@nvidia.com>
CC:     Aapo Vienamo <avienamo@nvidia.com>,
        Prashant Gaikwad <pgaikwad@nvidia.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        <linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>
References: <1531154338-3998-1-git-send-email-avienamo@nvidia.com>
 <1531154338-3998-3-git-send-email-avienamo@nvidia.com>
 <5805047f-4099-db34-0759-42e4a9e11629@nvidia.com>
 <20180711080022.GB1636@tbergstrom-lnx.Nvidia.com>
 <ef90eb24-e993-9cc1-ac09-5afedeceba75@nvidia.com>
 <20180711111754.GC1636@tbergstrom-lnx.Nvidia.com>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <7022b1f4-97ac-aa1b-5c60-d7041da6704b@nvidia.com>
Date:   Wed, 11 Jul 2018 16:14:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180711111754.GC1636@tbergstrom-lnx.Nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/07/18 12:17, Peter De Schrijver wrote:
> On Wed, Jul 11, 2018 at 09:42:20AM +0100, Jon Hunter wrote:
>>
>> On 11/07/18 09:00, Peter De Schrijver wrote:
>>> On Tue, Jul 10, 2018 at 05:17:05PM +0100, Jon Hunter wrote:
>>>>
>>>> On 09/07/18 17:38, Aapo Vienamo wrote:
>>>>> From: Peter De Schrijver <pdeschrijver@nvidia.com>
>>>>>
>>>>> Move this to a separate file so it can be used to calculate the sdmmc
>>>>> clock dividers.
>>>>
>>>> Sorry for not commenting sooner, but what is the motivation for moving
>>>> this to its own file? I don't see why we need to do this in order to use
>>>> elsewhere. Furthermore, the original file is quite aptly named 'clk-divider.c'
>>>> and now we have a div71.c which seems quite specific.
>>>
>>> How else would you do it?
>>
>> Keep it in the same file?
>>
> 
> That seems odd. clk-divider.c is meant to implement a clock type, not
> utility functions we happen to need in several types.

I see, then why not have a clk-utils.c for stuff like this. I am painting
the bikeshed here, but div71.c seems very specific and I still don't
understand the 7.1 bit.

Cheers
Jon

-- 
nvpublic