Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp949922imm; Wed, 11 Jul 2018 14:04:10 -0700 (PDT) X-Google-Smtp-Source: AAOMgpf4tJwQGw5Nw0iWJkzJcUCyMOhwMll2QiI6y0bpGRX6H+3Mi2pSYJZAwuh5PiapT+7KpbkD X-Received: by 2002:a17:902:3303:: with SMTP id a3-v6mr186607plc.209.1531343050912; Wed, 11 Jul 2018 14:04:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531343050; cv=none; d=google.com; s=arc-20160816; b=BivIYfWaedoWqlDR97RsGivfUqY3ybWXkNO8dxTScGUGfbbS/0zjXic2goN6Si3MkN Rn05qU+HO+07BJntZr9rWMR5+1l3Kx+6vFxKQ6v/naJlu6YRuEUTb1YGBIW0eO9Ny0yd sJJ3BYmi6PDtn55rMQ3a9XhZWqzxCXpO40vqUIjoobfPZATQX2Kwtbj378bbyd+ZJfYt 0Qb3Gb2lZIXEvpJheYIzy9d+//seGnWa3sYsRu0OAgO2yan/6pLr/gInwqtFtZJOtldb IAGeElHLqdIgzt2RXJwRruxMJVIt+88xVlcull24O2fxp2MYct6/85RWr0sDYJkWfFyZ 63wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=00wyPXl4xTf1IEolDKvFrSPBu+GzAssGPGCBgzCbyEc=; b=abKEk+QNskMoOHpz50oYOmBOpkFDxfYYOgsoAQSjYVCWmqjWaRfV+XisSBW8jpQc1+ 6PAD1rEIublU8THiwwwfbG7xbsuzPjtA9njm3faQMYsk7JjTBBb5grLXPtxVtoS6Bvvj oSgYGrDMQL1bFJn2RgpRlD5mFrdFZUahZWXY5FFVy8ab+jb5igavQ66ss18NGkHc0sS4 nLr+pTgEicBAj2pDCjUd6uCmUbW1OCjKfcMztOJzCn3W8zGCdo9WbXAcbjeRBRIOXNje 7Qf+cTpKi4HKncMv5TaoDDWvsq9vplaq1GDzWgN9kpDvsilwAmTZYAV5I8QzPdb22ZI1 YKdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=M83ermzm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e5-v6si18436244pgs.449.2018.07.11.14.03.55; Wed, 11 Jul 2018 14:04:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=M83ermzm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388818AbeGKPgP (ORCPT + 99 others); Wed, 11 Jul 2018 11:36:15 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52296 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732425AbeGKPgO (ORCPT ); Wed, 11 Jul 2018 11:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=00wyPXl4xTf1IEolDKvFrSPBu+GzAssGPGCBgzCbyEc=; b=M83ermzmqI0y0Iqh/p3tlRlo9z y9UaIXnFJbaJaM/mEnVL6V8cnRV6kDswOXAcd7oslIUuon9kP1D9n7iAZXe11jrVsg+DbKDZPq04y rtw11LaOAbMQEd76ZnsPtxQ628hOXz4lIodeqePIo7VGGPuXCNnP8YzrctaQeyL4BNJIYJj13L2Pw eFN71bFj7rlRFgTjdE5acNClR0f3X8SZzh4BdbJpFJlwXiBlcgAJQQcBEigbwgiUd6pVlSUcV3mv5 5OatjyVaV3/4jobJrzvn0HQ+0l9VdMonP4EqLdVhJAUHUmv/6eNpYMIOBjoZSHY1fwLwxnOvd+Nh9 +H12pALA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1fdH4p-0003wY-Bi; Wed, 11 Jul 2018 15:30:47 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id BF58A20297EAB; Wed, 11 Jul 2018 17:30:44 +0200 (CEST) Date: Wed, 11 Jul 2018 17:30:44 +0200 From: Peter Zijlstra To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Dave Hansen , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , "Ravi V. Shankar" , Vedvyas Shanbhogue Subject: Re: [RFC PATCH v2 18/27] x86/cet/shstk: Introduce WRUSS instruction Message-ID: <20180711153044.GK2476@hirez.programming.kicks-ass.net> References: <20180710222639.8241-1-yu-cheng.yu@intel.com> <20180710222639.8241-19-yu-cheng.yu@intel.com> <20180711094448.GZ2476@hirez.programming.kicks-ass.net> <1531321615.13297.9.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1531321615.13297.9.camel@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 11, 2018 at 08:06:55AM -0700, Yu-cheng Yu wrote: > On Wed, 2018-07-11 at 11:44 +0200, Peter Zijlstra wrote: > > What happened to: > > > > ? https://lkml.kernel.org/r/1528729376.4526.0.camel@2b52.sc.intel.com > > Yes, I put that in once and realized we only need to skip the > instruction and return err. ?Do you think we still need a handler for > that? I find that other form more readable, but then there's Nadav doing asm macros to shrink inline asm thingies so maybe he has another suggestion.