Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp951657imm;
        Wed, 11 Jul 2018 14:06:00 -0700 (PDT)
X-Google-Smtp-Source: AAOMgpcDBZ0FCCq3ordCdNPxsOCfclH3OPdcUuM6wr72DsZw7XZEUijUBnRNpv3mvDcgVm9J6keE
X-Received: by 2002:a63:d8:: with SMTP id 207-v6mr213366pga.94.1531343160821;
        Wed, 11 Jul 2018 14:06:00 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1531343160; cv=none;
        d=google.com; s=arc-20160816;
        b=rfkBzOIpBvr5GS8XI3do+lDRHDTl120Oq8Ve7AhJKJ35aUWZzR1s3hOVgnfjjnsQcu
         DcthMbGw6AADUDQyffb/XG0Cg7GFYW7bfnFn0katDjgVwm4RUNHQzPHPv4dU1C+phL4+
         AxTxTzVizLx7uHjW1FKjeFyKTUgqVQrl2b8lyZQT1Dfu+kM4zt2Zz9fIQQnFZhBsBQZv
         tdHCI4g0W6brYeiQMjXLzfwcsAiwp6hRavYS47DvFxlqVR6AYTjmRZuEDYGq/169TuAM
         iEUaPb/HLAdc/+7EviqRsNw3cRK/d2d+jEc7Dxddf8o4EDfgzxDB/CqonEn29Al89gw2
         +b+w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id
         :arc-authentication-results;
        bh=tw9UH/GHhxL7Vuuv2Dxi2O+zzGJqGWZuDeP5TrsaRcA=;
        b=Q1j+uwVifXyAeGjuyhJ3elcW+DQ6483CP+peJOqfQWGq3Me9Atq7DevEYCGM8AAvPW
         KXehhv7SVyAAfsMmQb8XsbZ/3jjzLLLgjJ5SLHadeU7XE3vqOX/HP5YNJErbYT52Ag00
         yV9obZNBfTb3pDAoW/8TXsQB4i/s5MLaMfBJWNXl1JSwH1neeiogxN/YElm+bJ9+/dL5
         Gtq+ehhupD9cxoIgrAWc8ccz2t9HqWBWHimx6yFRqvDLXzuMpC5QLuJoIjQD054fPvyn
         ckrzaoB37Y3n9MRBD4E4bvyJXcyzbxeBtCrPZGGE5FFQFpPqmjC5Gl65WtK8sZIvxdn/
         vF7w==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id c21-v6si8750147pls.407.2018.07.11.14.05.45;
        Wed, 11 Jul 2018 14:06:00 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2389492AbeGKPxk (ORCPT <rfc822;jimmypw@gmail.com> + 99 others);
        Wed, 11 Jul 2018 11:53:40 -0400
Received: from mga05.intel.com ([192.55.52.43]:50317 "EHLO mga05.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1732935AbeGKPxk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jul 2018 11:53:40 -0400
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 08:48:43 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.51,338,1526367600"; 
   d="scan'208";a="239537221"
Received: from 2b52.sc.intel.com ([143.183.136.52])
  by orsmga005.jf.intel.com with ESMTP; 11 Jul 2018 08:48:42 -0700
Message-ID: <1531323904.13297.26.camel@intel.com>
Subject: Re: [RFC PATCH v2 17/27] x86/cet/shstk: User-mode shadow stack
 support
From:   Yu-cheng Yu <yu-cheng.yu@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-mm@kvack.org,
        linux-arch@vger.kernel.org, linux-api@vger.kernel.org,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@amacapital.net>,
        Balbir Singh <bsingharora@gmail.com>,
        Cyrill Gorcunov <gorcunov@gmail.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Florian Weimer <fweimer@redhat.com>,
        "H.J. Lu" <hjl.tools@gmail.com>, Jann Horn <jannh@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Kees Cook <keescook@chromiun.org>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Oleg Nesterov <oleg@redhat.com>, Pavel Machek <pavel@ucw.cz>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Vedvyas Shanbhogue <vedvyas.shanbhogue@intel.com>
Date:   Wed, 11 Jul 2018 08:45:04 -0700
In-Reply-To: <20180711093454.GX2476@hirez.programming.kicks-ass.net>
References: <20180710222639.8241-1-yu-cheng.yu@intel.com>
         <20180710222639.8241-18-yu-cheng.yu@intel.com>
         <20180711093454.GX2476@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2018-07-11 at 11:34 +0200, Peter Zijlstra wrote:
> On Tue, Jul 10, 2018 at 03:26:29PM -0700, Yu-cheng Yu wrote:
> > 
> > +/* MSR_IA32_U_CET and MSR_IA32_S_CET bits */
> > +#define MSR_IA32_CET_SHSTK_EN		0x0000000000000001
> > +#define MSR_IA32_CET_WRSS_EN		0x0000000000000002
> > +#define MSR_IA32_CET_ENDBR_EN		0x0000000000000004
> > +#define MSR_IA32_CET_LEG_IW_EN		0x0000000000000008
> > +#define MSR_IA32_CET_NO_TRACK_EN	0x0000000000000010
> Do those want a ULL literal suffix?

I will fix it.