Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1072962imm; Wed, 11 Jul 2018 16:44:16 -0700 (PDT) X-Google-Smtp-Source: AAOMgpcGXVQgrydpcm6Fu6ow7+tN0ZY2R1xBDx7KVNTJmlfqJdI865SRngiZhc6dU7rTp44KcLaM X-Received: by 2002:a17:902:7892:: with SMTP id q18-v6mr579635pll.331.1531352656548; Wed, 11 Jul 2018 16:44:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531352656; cv=none; d=google.com; s=arc-20160816; b=eFrsrNsAIiw7Mj0jhQJmEtzkYxmgtWgZmAjUQOduDLGIDnEp/A7ymWmwRDXFEPs4qf tvPULjngAmap9DMUdFM8eLdqubWOY7drTvEaWfyuOoKvYd0aOq1mLfPyW0TK3eT91Wo0 maJjN0ANktEhXmg+Gx42fipTlJ5M1N9tFwqx9gVm+lb0Q8a5qN0WAlORIjInPgPRnXOX ISwUuM7+PM7favRBiwil82aXeX5TC1MjbaY3IAaseQpEqIOqjXc2baijglQECRE+hIAN A8a7KfsCt94ISK+BxoePwzHmRL6JqyCfpTDT6BxpEoU461FeI41MyXV1wtSZNgTEN4yp 7g8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=k+zAhmil+9lgRJv90gr9XQ28qx9ejR8w8cpaK7UxjHg=; b=U7Y8h05F3u9LA28m7AnSUiIu1wXZthv+183ggnqEUXswCbHCmrdMiNDoYvXWn+OKq8 9e60vYwlCAkVxQLhHF5zmM4H3AQfZ2RBUpQoBVHlMz518j83q/rmWc6MbEyO15hWl0bH yQOw79+2dAuzSmi0bJ7N3AQI5GYSAk9Pqj6YjoMULrg3uFus3+ZnYoirQrLTM7MiKpnc 3fOzGED5pXAC8uyHi12pymo5M2hTXpRZl4e4HphuUUTPGPUmkR1NIdRPcPvkMmBjKRkT UKGa3CWoTs5+O0EWd5ic2w/lYLTRK8sVO/4h1CypkCMIFzLFNBkENO+SDUrZcpfKpFwR Akwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BaVyHl3J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o123-v6si15551659pfg.5.2018.07.11.16.44.01; Wed, 11 Jul 2018 16:44:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=BaVyHl3J; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389989AbeGKRGd (ORCPT + 99 others); Wed, 11 Jul 2018 13:06:33 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:36854 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726460AbeGKRGc (ORCPT ); Wed, 11 Jul 2018 13:06:32 -0400 Received: by mail-pl0-f66.google.com with SMTP id a7-v6so9424500plp.3; Wed, 11 Jul 2018 10:01:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k+zAhmil+9lgRJv90gr9XQ28qx9ejR8w8cpaK7UxjHg=; b=BaVyHl3JKlmmCOlFjVepWvafZCPiNpgaGkTASSGf6fy+sm8bk25iOKKX2gYHKVwoQp 1m/E2bQS0AXpQjAw852M3hqFw4+5j9xnZAKz5PHn7YObGgxHkNNa/bnF5tl1bOY5yegW 43xrLWyb4wsVO0JOatbrZYAP2j+vinbfzhqK9y8DNfdrlSHDMbrR8dL2dr1fC7/TaObI 5cVBhYxTjzFAUP1nlLDmP51dTvYmD2GqRGeE52w1KEEOSxFH40wYbh96srYaF89CAlg7 cHeHJqlse3r5lG9rdF9RgHW/tHzAhwvc0RkoeTekvcG99u58ZbT8IhnvA4alwbh9aFOv A7dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+zAhmil+9lgRJv90gr9XQ28qx9ejR8w8cpaK7UxjHg=; b=bA4bVQvgqs/ysJOS5vp67jol14oSVUD1YtR9qoiTcXTSN6aiHVh4vu6LYhtv8mee3A dbBB34FkJZRmmjSbgdDnYbVmnCbVDINxxvVHH9BIT0uQvDBdPrVRypVydqzDh7NX6+/t eZDYucjrCgOSCxUI1GhFAUT25umMWfxg7dbRgqwp9LU0SS75+otCVqkcMBXYwtwdBLvW Adm6OjPEEL7J2kPDJLxqW809ISt7f8AFAt/HaLhJ2YxIf9J2MwnJ2qNFtUVctv0IitFj YTLDlmAsHzyPkelHTrIQV2nNVIdpp8HbBdh7XWaFFuKLH1ry2xYjVOU+ZYxt6S6abBWQ WJ6A== X-Gm-Message-State: APt69E0xbmwz4aydYbAvVR59voJNjbFRvKR6Bumq9WMnekIejbGMVIpF AF3Z7YIawmYNTOaluR43YoQ= X-Received: by 2002:a17:902:7e43:: with SMTP id a3-v6mr29204801pln.151.1531328478647; Wed, 11 Jul 2018 10:01:18 -0700 (PDT) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id m10-v6sm28638268pgq.89.2018.07.11.10.01.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jul 2018 10:01:17 -0700 (PDT) Subject: Re: [PATCH net-next 1/2] tcp: remove redundant rcv_nxt update To: Yafang Shao , davem@davemloft.net, edumazet@google.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, shaoyafang@didichuxing.com References: <1531315019-3553-1-git-send-email-laoar.shao@gmail.com> From: Eric Dumazet Message-ID: Date: Wed, 11 Jul 2018 10:01:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1531315019-3553-1-git-send-email-laoar.shao@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2018 06:16 AM, Yafang Shao wrote: > tcp_rcv_nxt_update() is already executed in tcp_data_queue(). > This line is redundant. > > See bellow, > tcp_queue_rcv > tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq); > tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant > > Signed-off-by: Yafang Shao > --- This patch is fine (but not the following) Signed-off-by: Eric Dumazet Thanks.