Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1167212imm; Wed, 11 Jul 2018 19:05:12 -0700 (PDT) X-Google-Smtp-Source: AAOMgpfHBsGqV9eijnPHQaO3Dy2aQ8BFP3/7AaEYo13P3I0T0SJhUREfFaWdZkyMQ6vt+rUJKagX X-Received: by 2002:a17:902:4324:: with SMTP id i33-v6mr306396pld.43.1531361112341; Wed, 11 Jul 2018 19:05:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531361112; cv=none; d=google.com; s=arc-20160816; b=CTo18Ol7Ar0zP0L2vNAjSm67SIZ0uEK4mCSe+j0cAO72qVgKOe97qUWEh+UZR+XcE+ XwJ3+GgeOx1CrcSJG3VHXTDEi3y4qIuQP+VzCOso+IyNqLmiIlEb3Em3YU8C3d/uNzy4 w+hvgimNejHDjnHtyo689Z5bm1Rt6mUa09zhf1EZhCxnEkWHiXpVMHmDXRq3Kh8VOV+1 94X+dr8ZaBkcaibSbUr38dYpftuTH7lo5wq0TeydiWnIZfeMZV8srr0SqE26kT56IZB8 FyQB5ImBAkUlfXTW6jCogRdw08xLi8PzOtoHSBvTyQgs3cU0kndLFOElT8y9Wb2m10uo /2BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=tP+V3Borxh0U/KXDOHt/QpWaHV3pNZI43ehZ4rhT/GA=; b=h5R4izmXTGTM6iXRpwFLy0UOhi3/mqPX4fr/6/V5Z0VRdVrOosh9Tp0zS/abi7C0yq p3WOXgpVNRgqjwMwo+WIihoSY28TSnCJaKWWCevo385rYrEbQ5DQLAvIObxS2lQlnR0N 51rHSaepj4f7UiZQN5lxYli5ITT1a0AYDWd5W2a3Dy5lM9avjuwCQaqlIUga5DSqwlHN H3LRN7xiihD1+/NKb7bU6stLlKcqGjmF6cF2WUj/2HRoJ2IvUt3+BlgXpPbwH6FpoUZy eQf23v09fCtRaB+9yb3eTkonuW8hrTh6wd4DT8cYWHBRXmxc0103R7kgiy35p10nDtvg iffQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=alWxyPZo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b39-v6si21587087pla.26.2018.07.11.19.04.57; Wed, 11 Jul 2018 19:05:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=alWxyPZo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388255AbeGKUFn (ORCPT + 99 others); Wed, 11 Jul 2018 16:05:43 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:48662 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732979AbeGKUFn (ORCPT ); Wed, 11 Jul 2018 16:05:43 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w6BJsElc018749; Wed, 11 Jul 2018 19:59:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=tP+V3Borxh0U/KXDOHt/QpWaHV3pNZI43ehZ4rhT/GA=; b=alWxyPZoDL+G0cqV3fgTPd1uVu/tIBW40DFAO0WEO0JT+lhsdQ6mb3hSXbbTmUzuw2Zq rU+KZR025NbjIXDO0Hs+khH3gUfpuROSZ2L8qyhVqMxbqKhLiiGXsgQnjs6KdLD8Jk6z M25yx+s5r32hiiTy8Cty9bl36JbVbYyETLpt5LEcxGZoy+dR18AOxzi2LIpUwS3n9Avo eyuGmiUI4JCjAZnsjAvarTX2YhmtSVdyu3uQJk1guJPQ/NZaOs3Foi5JHbY8plEwMT3R ZpV1rcgEM1Tsn1enFP7SMBddrffbfof2Y1C8R/4uQY7LB6l926XZ4CdjIUYGONZbSfvK aA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2k2p7dyqbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jul 2018 19:59:38 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w6BJxXvL007447 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 11 Jul 2018 19:59:36 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w6BJxUFk008044; Wed, 11 Jul 2018 19:59:30 GMT Received: from monkey.oracle.com (/50.38.38.67) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 11 Jul 2018 12:59:30 -0700 From: Mike Kravetz To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: "Aneesh Kumar K . V" , Michael Ellerman , Benjamin Herrenschmidt , Michal Hocko , Cannon Matthews , Andrew Morton , Mike Kravetz Subject: [PATCH] mm/hugetlb: remove gigantic page support for HIGHMEM Date: Wed, 11 Jul 2018 12:59:13 -0700 Message-Id: <20180711195913.1294-1-mike.kravetz@oracle.com> X-Mailer: git-send-email 2.17.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8951 signatures=668706 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1806210000 definitions=main-1807110211 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit ee8f248d266e ("hugetlb: add phys addr to struct huge_bootmem_page") At one time powerpc used this field and supporting code. However that was removed with commit 79cc38ded1e1 ("powerpc/mm/hugetlb: Add support for reserving gigantic huge pages via kernel command line"). There are no users of this field and supporting code, so remove it. Signed-off-by: Mike Kravetz --- include/linux/hugetlb.h | 3 --- mm/hugetlb.c | 9 +-------- 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index 36fa6a2a82e3..c39d9170a8a0 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -348,9 +348,6 @@ struct hstate { struct huge_bootmem_page { struct list_head list; struct hstate *hstate; -#ifdef CONFIG_HIGHMEM - phys_addr_t phys; -#endif }; struct page *alloc_huge_page(struct vm_area_struct *vma, diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 430be42b6ca1..e39593df050b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2139,16 +2139,9 @@ static void __init gather_bootmem_prealloc(void) struct huge_bootmem_page *m; list_for_each_entry(m, &huge_boot_pages, list) { + struct page *page = virt_to_page(m); struct hstate *h = m->hstate; - struct page *page; -#ifdef CONFIG_HIGHMEM - page = pfn_to_page(m->phys >> PAGE_SHIFT); - memblock_free_late(__pa(m), - sizeof(struct huge_bootmem_page)); -#else - page = virt_to_page(m); -#endif WARN_ON(page_count(page) != 1); prep_compound_huge_page(page, h->order); WARN_ON(PageReserved(page)); -- 2.17.1