Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1203988imm; Wed, 11 Jul 2018 20:04:43 -0700 (PDT) X-Google-Smtp-Source: AAOMgpe50gloyCvgE8F4g+XJyVmKHnIDrU5KAFogrwuSBXmaRKDBKDNfEpj229XNgvhfe+2WcPHV X-Received: by 2002:a63:2404:: with SMTP id k4-v6mr425069pgk.191.1531364683084; Wed, 11 Jul 2018 20:04:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531364683; cv=none; d=google.com; s=arc-20160816; b=TMKnHrmNJj1wKm4nXMlOrJeEsgNVedLgxZbNdWePCMM08Asnz6iLv21HWAD+S5/avI hckvw2hUOmXzuhFV7lNLVJdImeUbWEhACi4DlLXxaHKe3jcwi5T1JVI8D9RIk3BL3lKu ovMJYqyBFViTBCW8sVMZxDtnan95VzZdJ003hjgOEFXho567/vYN/0lA6Gk2DTbdjqnO qEAKxZJ3MXuwRcGwuHgOcxOLTLIdLDl6922Ljou5UwjPM05fNuFUp1qYVDs8zFjDu91Q r186rhH3Ck652/Zs5+6cwAh3y/Ps8N1nTAGmVFO6BVna0tsCEjva4kE0+rH6AoAjJans dDJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=4eDa0gB3wMG5KkgBQlGej+qHhpZeT/gSuonemVnEz4E=; b=qCDO37EsK2YX6maS0l0/vLOCbmzg3cZZ/yM02NBTeC3g9hPaf74NTohGYZTSt5KwHt xt5yyDzyCs1nEMiianiLs0L2rYZY8t1SKubG9jwA0lAw9pUoERxAzGzm3cVUdnrZI3wp iIBOQlvyXkOf7xmCrSN3bf8W68EYwGDbJFk11YbUIOo4GbuFp78UW6OeCrND6EESq113 4C/uqMpYiHLW2lyjd4hdhHT07cIiyegcDh69Vu7PqBDfNBRyEcRHhAEhTvXOI/QiybRa I8XGHPSWBo6+l9zP4zkGJLK5MAzM0P2drI3SITTM5nz4HpYISc38VehJVuUlFgHctYry LXsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p12-v6si21292540pll.142.2018.07.11.20.04.27; Wed, 11 Jul 2018 20:04:43 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390726AbeGKXMZ (ORCPT + 99 others); Wed, 11 Jul 2018 19:12:25 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:46590 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388096AbeGKXMY (ORCPT ); Wed, 11 Jul 2018 19:12:24 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.9.92]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id AB0FBE33; Wed, 11 Jul 2018 23:05:48 +0000 (UTC) Date: Wed, 11 Jul 2018 16:05:47 -0700 From: Andrew Morton To: Daniel Vetter Cc: NeilBrown , LKML , DRI Development , Intel Graphics Development , Gustavo Padovan , Maarten Lankhorst , Sean Paul , David Airlie , Kees Cook , Ingo Molnar , Greg Kroah-Hartman , Wei Wang , Stefan Agner , Andrei Vagin , Randy Dunlap , Andy Shevchenko , Yisheng Xie , Peter Zijlstra , Daniel Vetter Subject: Re: [PATCH] kernel.h: Add for_each_if() Message-Id: <20180711160547.59f086a587c7f3c8d3c40f0f@linux-foundation.org> In-Reply-To: References: <20180709083650.23549-1-daniel.vetter@ffwll.ch> <20180709162509.29343-1-daniel.vetter@ffwll.ch> <20180709163001.8fb8148223a57bc46a13fbda@linux-foundation.org> <20180710075328.GG3008@phenom.ffwll.local> <871scbwfd4.fsf@notabene.neil.brown.name> X-Mailer: Sylpheed 3.6.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jul 2018 13:51:08 +0200 Daniel Vetter wrote: > But I still have the situation that a bunch of maintainers acked this > and Andrew Morton defacto nacked it, which I guess means I'll keep the > macro in drm? The common way to go about this seems to be to just push > the patch series with the ack in some pull request to Linus and ignore > the people who raised questions, but not really my thing. Heh. But, am I wrong? Code which uses regular kernel style doesn't have these issues. We shouldn't be enabling irregular style - we should be making such sites more regular. The fact that the compiler generates a nice warning in some cases simply helps us with that.