Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 12 Jul 2018 15:09:55 +0800
In-Reply-To: <20180712064601.m3bdd46wzac5fpgh@flea>
References: <20180711132233.42301-1-icenowy@aosc.io> <20180711132233.42301-2-icenowy@aosc.io> <20180711150532.6gzm7krouriddreh@flea> <8F6CDF5C-2AC1-43EC-858A-5C6345CF279A@aosc.io> <20180712064601.m3bdd46wzac5fpgh@flea>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 8BIT
Subject: Re: [linux-sunxi] Re: [PATCH 1/2] ARM: sun8i: h3: enable HDMI output on Banana Pi M2 Zero
To:     linux-arm-kernel@lists.infradead.org,
        Maxime Ripard <maxime.ripard@bootlin.com>
CC:     devicetree@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
        linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org
From:   Icenowy Zheng <icenowy@aosc.io>
Message-ID: <A7CA2831-7117-415C-BC59-3FB4AE425598@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


于 2018年7月12日 GMT+08:00 下午2:46:01, Maxime Ripard <maxime.ripard@bootlin.com> 写到:
>On Wed, Jul 11, 2018 at 11:15:50PM +0800, Icenowy Zheng wrote:
>> 
>> 
>> 于 2018年7月11日 GMT+08:00 下午11:05:32, Maxime Ripard
><maxime.ripard@bootlin.com> 写到:
>> >Hi,
>> >
>> >On Wed, Jul 11, 2018 at 09:22:32PM +0800, Icenowy Zheng wrote:
>> >> Banana Pi M2 Zero board has a miniHDMI port connected to the HDMI
>> >> controller of Allwinner H3 SoC.
>> >> 
>> >> Enable the HDMI output in Banana Pi M2 Zero device tree.
>> >> 
>> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
>> >> ---
>> >>  .../dts/sun8i-h2-plus-bananapi-m2-zero.dts    | 25
>> >+++++++++++++++++++
>> >>  1 file changed, 25 insertions(+)
>> >> 
>> >> diff --git a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> index 7d01f9322658..eb61dcf32797 100644
>> >> --- a/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> +++ b/arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts
>> >> @@ -26,6 +26,17 @@
>> >>  		stdout-path = "serial0:115200n8";
>> >>  	};
>> >>  
>> >> +	hdmi-connector {
>> >> +		compatible = "hdmi-connector";
>> >> +		type = "c";
>> >
>> >This is not one of the connector type declared in DRM, how is it
>> >exposed to the userspace?
>> 
>> So just use "A" here (because of single link)?
>
>If the connector type is C, it should be C, and DRM / driver adjusted
>to handle it.

Okay I won't change this property, if there's any further revisions.

For DRM driver, I think it can be an independent patchset.

>
>Maxime