Received: by 2002:ac0:a5a7:0:0:0:0:0 with SMTP id m36-v6csp1370212imm; Thu, 12 Jul 2018 00:14:39 -0700 (PDT) X-Google-Smtp-Source: AAOMgpeAPI2Jv+AT4a24nm1plgv9MpzrhI5hwzwV83k2ykLgJj1xh3gcG1Kupj5bZ+aqgIkqyOP2 X-Received: by 2002:a17:902:ab95:: with SMTP id f21-v6mr1028256plr.264.1531379679523; Thu, 12 Jul 2018 00:14:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1531379679; cv=none; d=google.com; s=arc-20160816; b=mTvCQF6bhdbYQzU4/ldjxap3S7p7GzJBzQ9JKMLw/kN1WpGDW8vVZUNTRb29iWkKQf KYNo2+uaIkt9tYnIrk5aW8jzxgz2GPY+NV4tQcOijPwhb+mt/rajFeuk/2jSU1vJQmrt K7CeOWAr5RQ2Ky9sjqLb/mXBr8aXpNw8nth4k4kFqHEviOgMVg57qpOd6W8krcdc6VXU 8YYKoiGtr/Afb2r40vAXvIwnlxJ1fLSHz5eY8OOzlgaM55P8kPXxOscqTfx7fPjz96N3 7K40m7pNy9/3uKPEixFAA0NNcwYTD1dSyVAXfZcXvMD7+OJFoQWm27JsYFmy+0AKhRs+ gAjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=8/uqiNJDSjYKjGjQ+O1QiWW7Tr7VskrPzTx7T7YMG3s=; b=RfSHG4DzqaHixgoetHMSxKcIt4Dd1Q4zOsAfrrGj18Bg/EAniahEeepDeKNHWp+1qP Kr9gFVzLzZ2vMomdvg8+C6DEN4G7SRtuRgBrDVsYGqTvIfWTHAQWm0dGi9nJ/xnjK4hX WPOiLoZdiWH7qiQcasWjIGx6n6Un8V1jXs+9CEzm3zHU7qgy5U7UEQuStmHErCjfZ/cK CClJBg4uSoum/1VHGylLoI2ERv+qW7VKt0SdY4C7zQBjQEBCzfnOnQFKZmAPRpDR6woz Z/XcEm+0jcVLVK5+8uYo1IQPzC5EM6R9ttSC5pVXxHfaoefRZKTJpW9Yjv5V6qIl7dR7 3AtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d2-v6si20115450pge.404.2018.07.12.00.14.23; Thu, 12 Jul 2018 00:14:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726597AbeGLHWC (ORCPT + 99 others); Thu, 12 Jul 2018 03:22:02 -0400 Received: from verein.lst.de ([213.95.11.211]:57004 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbeGLHWC (ORCPT ); Thu, 12 Jul 2018 03:22:02 -0400 Received: by newverein.lst.de (Postfix, from userid 2407) id 8B3C86FB7B; Thu, 12 Jul 2018 09:15:36 +0200 (CEST) Date: Thu, 12 Jul 2018 09:15:36 +0200 From: Christoph Hellwig To: Joonsoo Kim Cc: Michal Hocko , Marek Szyprowski , Linux Memory Management List , LKML , linux-arm-kernel@lists.infradead.org, linuxppc-dev , iommu@lists.linux-foundation.org, Andrew Morton , Michal Nazarewicz , Joonsoo Kim , Vlastimil Babka , Christoph Hellwig , Russell King , Catalin Marinas , Will Deacon , Paul Mackerras , Benjamin Herrenschmidt , Chris Zankel , Martin Schwidefsky , Joerg Roedel , Sumit Semwal , Robin Murphy , Laura Abbott , linaro-mm-sig@lists.linaro.org Subject: Re: [PATCH 1/2] mm/cma: remove unsupported gfp_mask parameter from cma_alloc() Message-ID: <20180712071536.GA15506@lst.de> References: <20180709121956.20200-1-m.szyprowski@samsung.com> <20180709122019eucas1p2340da484acfcc932537e6014f4fd2c29~-sqTPJKij2939229392eucas1p2j@eucas1p2.samsung.com> <20180710095056.GE14284@dhcp22.suse.cz> <20180711085407.GB20050@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 12, 2018 at 11:48:47AM +0900, Joonsoo Kim wrote: > One of existing user is general DMA layer and it takes gfp flags that is > provided by user. I don't check all the DMA allocation sites but how do > you convince that none of them try to use anything other > than GFP_KERNEL [|__GFP_NOWARN]? They use a few others things still like __GFP_COMP, __GPF_DMA or GFP_HUGEPAGE. But all these are bogus as we have various implementations that can't respect them. I plan to get rid of the gfp_t argument in the dma_map_ops alloc method in a few merge windows because of that, but it needs further implementation consolidation first.